All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] Fix memstat's install
Date: Tue, 21 Jul 2009 22:05:15 +0200	[thread overview]
Message-ID: <874ot5er9g.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090721104808.7013677806@busybox.osuosl.org> (Bernhard Reutner-Fischer's message of "Tue\, 21 Jul 2009 12\:47\:38 +0200")

>>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:

Hi,

A bit more detailed changelog would be good.

 Bernhard> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
 Bernhard> ---
 Bernhard>  package/memstat/memstat.mk |    8 +++++---
 Bernhard>  1 files changed, 5 insertions(+), 3 deletions(-)

 Bernhard> diff --git a/package/memstat/memstat.mk b/package/memstat/memstat.mk
 Bernhard> index 7220aee..a54509a 100644
 Bernhard> --- a/package/memstat/memstat.mk
 Bernhard> +++ b/package/memstat/memstat.mk
 Bernhard> @@ -21,15 +21,17 @@ $(MEMSTAT_DIR)/.configured: $(MEMSTAT_DIR)/.unpacked
 Bernhard>  	touch $@
 
 Bernhard>  $(MEMSTAT_DIR)/memstat: $(MEMSTAT_DIR)/.configured
 Bernhard> -	$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) $(@D)/memstat.c -o $@
 Bernhard> +	$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) \
 Bernhard> +		$(CFLAGS_WHOLE_PROGRAM) $(@D)/memstat.c -o $@

What is this WHOLE_PROGRAM thing?
 
 Bernhard>  $(TARGET_DIR)/usr/bin/memstat: $(MEMSTAT_DIR)/memstat
 Bernhard>  	[ -e $(TARGET_DIR)/etc/memstat.conf ] || \
 Bernhard> -		$(INSTALL) -m 0644 -D $(^D)/memstat.conf $(TARGET_DIR)/etc
 Bernhard> +		$(INSTALL) -m 0644 -D $(^D)/memstat.conf \
 Bernhard> +			$(TARGET_DIR)/etc/memstat.conf
 Bernhard>  	$(INSTALL) -m 0755 -D $^ $@
 Bernhard>  	$(STRIPCMD) $(STRIP_STRIP_ALL) $@
 
 Bernhard> -memstat: uclibc $(TARGET_DIR)/usr/bin/memstat
 Bernhard> +memstat: $(TARGET_DIR)/usr/bin/memstat

And why this unrelated change?

Please post patches to the list before committing, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-07-21 20:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 10:47 [Buildroot] [git commit] Fix memstat's install Bernhard Reutner-Fischer
2009-07-21 20:05 ` Peter Korsgaard [this message]
2009-07-21 22:03   ` Bernhard Reutner-Fischer
2009-07-22  6:01     ` Peter Korsgaard
2009-07-22  7:46       ` Bernhard Reutner-Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ot5er9g.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.