All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] Fix memstat's install
Date: Wed, 22 Jul 2009 08:01:12 +0200	[thread overview]
Message-ID: <87ocrdcl3r.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090721220332.GJ14135@mx.loc> (Bernhard Reutner-Fischer's message of "Wed\, 22 Jul 2009 00\:03\:32 +0200")

>>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:

Hi,

 Bernhard> On Tue, Jul 21, 2009 at 10:05:15PM +0200, Peter Korsgaard wrote:

 >> A bit more detailed changelog would be good.

 Bernhard> Well, it does just that: Fix memstat's install stage (aka PR473) :)

For ancient versions of install. I would have preferred a commit
message like:

memstat: workaround issue with older versions of 'install'

Closes #473

Older versions of GNU install have issues with install -D <file>
<dir>/, but works with install -D <file> <dir>/<file>, so use that
instead.


And a corresponding addition to CHANGES

 Bernhard> $(MEMSTAT_DIR)/memstat: $(MEMSTAT_DIR)/.configured
 Bernhard> -	$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) $(@D)/memstat.c -o $@
 Bernhard> +	$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) \
 Bernhard> +		$(CFLAGS_WHOLE_PROGRAM) $(@D)/memstat.c -o $@
 >> 
 >> What is this WHOLE_PROGRAM thing?

 Bernhard> gcc --help=optimizers | grep whole-program

Yes, I know the -fwhole-program option, but why is this just not
included in TARGET_CFLAGS?

 >> Please post patches to the list before committing, thanks.

 Bernhard> I accidentally committed it to the wrong repo, my apologies.

Ahh, ok - May I suggest you clone the official repo with git://
instead of ssh:// to not do that mistake in the future?

Thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-07-22  6:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 10:47 [Buildroot] [git commit] Fix memstat's install Bernhard Reutner-Fischer
2009-07-21 20:05 ` Peter Korsgaard
2009-07-21 22:03   ` Bernhard Reutner-Fischer
2009-07-22  6:01     ` Peter Korsgaard [this message]
2009-07-22  7:46       ` Bernhard Reutner-Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocrdcl3r.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.