From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: grub 1.96 svn 20080813 and circular lvm2 metadata
Date: Fri, 29 Aug 2008 17:37:14 +0200 [thread overview]
Message-ID: <874p53j0id.fsf@xs4all.nl> (raw)
In-Reply-To: <48B80F04.2030702@nic.fi> (Vesa Jääskeläinen's message of "Fri, 29 Aug 2008 18:00:20 +0300")
Vesa Jääskeläinen <chaac@nic.fi> writes:
> Felix Zielcke wrote:
>> The Changelog entry should be seperate, i.e. not a diff against the
>> actual ChangeLog file but you can have it above inside your patch
>> For example here my last small patch send to the list
>
> That is perfectly fine there :)
>
> Thou, you can also copy it within your email too. But everyone can spot
> it from patch too. Most important aspect is that it has to be there...
The problem is often when multiple files are patched, the ChangeLog
entry won't be the first in the list. Furthermore this makes a patch
harder to apply.
--
Marco
next prev parent reply other threads:[~2008-08-29 15:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 11:14 grub 1.96 svn 20080813 and circular lvm2 metadata Hans Lambermont
2008-08-28 11:25 ` Felix Zielcke
2008-08-29 9:00 ` Hans Lambermont
2008-08-29 9:31 ` Felix Zielcke
2008-08-29 15:00 ` Vesa Jääskeläinen
2008-08-29 15:22 ` Felix Zielcke
2008-08-29 15:37 ` Marco Gerards [this message]
2008-08-29 16:08 ` Marco Gerards
2008-09-03 6:49 ` Felix Zielcke
2008-09-03 21:15 ` Felix Zielcke
2008-09-08 10:28 ` Hans Lambermont
2008-09-09 13:03 ` Hans Lambermont
2008-09-23 8:29 ` Hans Lambermont
2008-09-23 8:58 ` Felix Zielcke
2008-09-24 9:45 ` Robert Millan
2008-09-30 12:34 ` Hans Lambermont
2008-10-05 10:50 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874p53j0id.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.