All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Cc: Jan Derk Gerlings <jan.derk.gerlings@newtec.eu>
Subject: Re: grub 1.96 svn 20080813 and circular lvm2 metadata
Date: Thu, 28 Aug 2008 13:25:11 +0200	[thread overview]
Message-ID: <1219922711.4598.49.camel@fz.local> (raw)
In-Reply-To: <20080828111405.GD8224@gagh.ehv.newtec.eu>

Am Donnerstag, den 28.08.2008, 13:14 +0200 schrieb Hans Lambermont:
> Hi all,

Hello,


> My colleague Jan Derk Gerlings found a bug in the way grub 1.96, svn
> version 20080813 (and earlier) reads the circular lvm2 metadata buffer.

Great, on Debian BTS we have 2 bugs [0] related to LVM and I wasn't able
yet to trace them down, but that could be the reason for them.


> Shall we attempt to fix this and send a patch ?

Yes please do :)

Because GRUB is a GNU project, you have to obey the GNU Coding Standards [1]

The Maintainer standards [2] says that on ~15 line changes you need to
assign copyright to FSF, but for this the others can tell you more after
you did your patch.

So just try to obey the coding style used in GRUB and please try to
write a changelog entry, see GCS as a manual and the changelog file for
examples 

[0] http://bugs.debian.org/462835
    http://bugs.debian.org/495949
[1] http://www.gnu.org/prep/standards/html_node/index.html
[2] http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant

-- 
Felix Zielcke




  reply	other threads:[~2008-08-28 11:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 11:14 grub 1.96 svn 20080813 and circular lvm2 metadata Hans Lambermont
2008-08-28 11:25 ` Felix Zielcke [this message]
2008-08-29  9:00   ` Hans Lambermont
2008-08-29  9:31     ` Felix Zielcke
2008-08-29 15:00       ` Vesa Jääskeläinen
2008-08-29 15:22         ` Felix Zielcke
2008-08-29 15:37         ` Marco Gerards
2008-08-29 16:08     ` Marco Gerards
2008-09-03  6:49       ` Felix Zielcke
2008-09-03 21:15       ` Felix Zielcke
2008-09-08 10:28         ` Hans Lambermont
2008-09-09 13:03         ` Hans Lambermont
2008-09-23  8:29           ` Hans Lambermont
2008-09-23  8:58             ` Felix Zielcke
2008-09-24  9:45               ` Robert Millan
2008-09-30 12:34                 ` Hans Lambermont
2008-10-05 10:50                   ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219922711.4598.49.camel@fz.local \
    --to=fzielcke@z-51.de \
    --cc=grub-devel@gnu.org \
    --cc=jan.derk.gerlings@newtec.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.