From: Jakob Bornecrantz <jakob@vmware.com>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: Don't clear page metadata of imported sg pages
Date: Wed, 5 Feb 2014 06:37:25 -0800 (PST) [thread overview]
Message-ID: <875572983.13196562.1391611045498.JavaMail.root@vmware.com> (raw)
In-Reply-To: <1391589243-10467-1-git-send-email-thellstrom@vmware.com>
----- Ursprungligt meddelande -----
> These page pointers shouldn't be visible to TTM in the first place, but
> until we fix that up, don't clear the page metadata because that
> will upset the exporter.
>
> Reported-by: Cristoph Haag <haagch.christoph@googleemail.com>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
> ---
> drivers/gpu/drm/ttm/ttm_tt.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Jakob Bornecrantz <jakob@vmware.com>
>
> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> index 9af9908..75f3190 100644
> --- a/drivers/gpu/drm/ttm/ttm_tt.c
> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> @@ -380,6 +380,9 @@ static void ttm_tt_clear_mapping(struct ttm_tt *ttm)
> pgoff_t i;
> struct page **page = ttm->pages;
>
> + if (ttm->page_flags & TTM_PAGE_FLAG_SG)
> + return;
> +
> for (i = 0; i < ttm->num_pages; ++i) {
> (*page)->mapping = NULL;
> (*page++)->index = 0;
> --
> 1.7.10.4
>
prev parent reply other threads:[~2014-02-05 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 8:34 [PATCH] drm/ttm: Don't clear page metadata of imported sg pages Thomas Hellstrom
2014-02-05 14:37 ` Jakob Bornecrantz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875572983.13196562.1391611045498.JavaMail.root@vmware.com \
--to=jakob@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.