All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	linux-pci@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] PCI: provide of_pci_get_host_bridge_resources helper
Date: Fri, 18 Dec 2015 16:02:41 +0100	[thread overview]
Message-ID: <8759253.sZisGJ6Km3@wuerfel> (raw)

The pcie-rcar driver can be built for any ARM platform (for COMPILE_TEST)
including those without CONFIG_OF enabled, and that results in a compile-time
error:

drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_parse_request_of_pci_ranges':
drivers/pci/host/pcie-rcar.c:939:8: error: implicit declaration of function 'of_pci_get_host_bridge_resources' [-Werror=implicit-function-declaration]
  err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pci->resources, &iobase);

In order to allow compile-testing on all platforms, this adds a
of_pci_get_host_bridge_resources() helper stub function that gets
used when CONFIG_OF_ADDRESS is disabled. This mirrors what we do for
other OF-specific functions.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5d2917d469fa ("PCI: rcar: Convert to DT resource parsing API")

diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h
index 2c51ee78b1c0..874d68f50a40 100644
--- a/include/linux/of_pci.h
+++ b/include/linux/of_pci.h
@@ -59,6 +59,14 @@ static inline void of_pci_check_probe_only(void) { }
 int of_pci_get_host_bridge_resources(struct device_node *dev,
 			unsigned char busno, unsigned char bus_max,
 			struct list_head *resources, resource_size_t *io_base);
+#else
+static inline
+int of_pci_get_host_bridge_resources(struct device_node *dev,
+			unsigned char busno, unsigned char bus_max,
+			struct list_head *resources, resource_size_t *io_base)
+{
+	return -EINVAL;
+}
 #endif
 
 #if defined(CONFIG_OF) && defined(CONFIG_PCI_MSI)


WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: provide of_pci_get_host_bridge_resources helper
Date: Fri, 18 Dec 2015 15:02:41 +0000	[thread overview]
Message-ID: <8759253.sZisGJ6Km3@wuerfel> (raw)

The pcie-rcar driver can be built for any ARM platform (for COMPILE_TEST)
including those without CONFIG_OF enabled, and that results in a compile-time
error:

drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_parse_request_of_pci_ranges':
drivers/pci/host/pcie-rcar.c:939:8: error: implicit declaration of function 'of_pci_get_host_bridge_resources' [-Werror=implicit-function-declaration]
  err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pci->resources, &iobase);

In order to allow compile-testing on all platforms, this adds a
of_pci_get_host_bridge_resources() helper stub function that gets
used when CONFIG_OF_ADDRESS is disabled. This mirrors what we do for
other OF-specific functions.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5d2917d469fa ("PCI: rcar: Convert to DT resource parsing API")

diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h
index 2c51ee78b1c0..874d68f50a40 100644
--- a/include/linux/of_pci.h
+++ b/include/linux/of_pci.h
@@ -59,6 +59,14 @@ static inline void of_pci_check_probe_only(void) { }
 int of_pci_get_host_bridge_resources(struct device_node *dev,
 			unsigned char busno, unsigned char bus_max,
 			struct list_head *resources, resource_size_t *io_base);
+#else
+static inline
+int of_pci_get_host_bridge_resources(struct device_node *dev,
+			unsigned char busno, unsigned char bus_max,
+			struct list_head *resources, resource_size_t *io_base)
+{
+	return -EINVAL;
+}
 #endif
 
 #if defined(CONFIG_OF) && defined(CONFIG_PCI_MSI)


WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: provide of_pci_get_host_bridge_resources helper
Date: Fri, 18 Dec 2015 16:02:41 +0100	[thread overview]
Message-ID: <8759253.sZisGJ6Km3@wuerfel> (raw)

The pcie-rcar driver can be built for any ARM platform (for COMPILE_TEST)
including those without CONFIG_OF enabled, and that results in a compile-time
error:

drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_parse_request_of_pci_ranges':
drivers/pci/host/pcie-rcar.c:939:8: error: implicit declaration of function 'of_pci_get_host_bridge_resources' [-Werror=implicit-function-declaration]
  err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pci->resources, &iobase);

In order to allow compile-testing on all platforms, this adds a
of_pci_get_host_bridge_resources() helper stub function that gets
used when CONFIG_OF_ADDRESS is disabled. This mirrors what we do for
other OF-specific functions.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5d2917d469fa ("PCI: rcar: Convert to DT resource parsing API")

diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h
index 2c51ee78b1c0..874d68f50a40 100644
--- a/include/linux/of_pci.h
+++ b/include/linux/of_pci.h
@@ -59,6 +59,14 @@ static inline void of_pci_check_probe_only(void) { }
 int of_pci_get_host_bridge_resources(struct device_node *dev,
 			unsigned char busno, unsigned char bus_max,
 			struct list_head *resources, resource_size_t *io_base);
+#else
+static inline
+int of_pci_get_host_bridge_resources(struct device_node *dev,
+			unsigned char busno, unsigned char bus_max,
+			struct list_head *resources, resource_size_t *io_base)
+{
+	return -EINVAL;
+}
 #endif
 
 #if defined(CONFIG_OF) && defined(CONFIG_PCI_MSI)

             reply	other threads:[~2015-12-18 15:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 15:02 Arnd Bergmann [this message]
2015-12-18 15:02 ` [PATCH] PCI: provide of_pci_get_host_bridge_resources helper Arnd Bergmann
2015-12-18 15:02 ` Arnd Bergmann
2016-01-04 13:21 ` Wolfram Sang
2016-01-04 13:21   ` Wolfram Sang
2016-01-04 13:21   ` Wolfram Sang
2016-01-04 20:22 ` Simon Horman
2016-01-04 20:22   ` Simon Horman
2016-01-04 20:22   ` Simon Horman
2016-01-08 16:43 ` Bjorn Helgaas
2016-01-08 16:43   ` Bjorn Helgaas
2016-01-08 16:43   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8759253.sZisGJ6Km3@wuerfel \
    --to=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=phil.edworthy@renesas.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.