From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Ping-Ke Shih" <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH rtw-next v2 1/2] wifi: rtw88: move the bmc high queue decision to tx.c
Date: Fri, 23 Oct 2026 21:34:31 +0000 [thread overview]
Message-ID: <875b4e96891a2bf256ca1805140b57aeccee4aed@linux.dev> (raw)
In-Reply-To: <5235fd68b703f756cc2ee1e7471339a512db59b8@linux.dev>
Hi Ping-Ke,
October 22, 2026 at 7:11 AM, "Luka Gejak" <luka.gejak@linux.dev> wrote:
>
> October 22, 2026 at 4:20 AM, "Ping-Ke Shih" <pkshih@realtek.com> wrote:
>
> >
> > Luka Gejak <luka.gejak@linux.dev> wrote:
> >
> >
> > USB decides in usb.c which broadcast and multicast (bmc) frames may use
> > the high queue. SDIO needs the same decision, so move the helpers to
> > tx.c behind a single exported rtw_tx_bmc_use_hiq() and keep the budget
> > state in struct rtw_dev.
> >
> > No functional change.
> >
> > By my review, I think it doesn't change logic at all, but I hope if
> > someone can help to test USB devices to confirm it still works well.
> >
> I ran the same test with rtl8723du and there is no regression.
>
> Best regards,
> Luka Gejak
>
I was thinking, as staging got removed, for 10-ish weeks(until 7.5)
users of RTL8723BS won't have AP mode. So I was wondering if these two
patches could pass as fixes into rc2 release(or whatever is the first
rc into which rtw tree is merged), as this would be DHCP stall fix. To
elaborate: when this driver was merged it, was exposingAP mode to
userspace, due to RTW88 doing it globally. Therefore AP mode existed,
but wasn't working properly. So maybe it's a bit of a stretch, but I
think it's a valid proposal to send it as a fix into next rc release.
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-10-23 21:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 12:43 [PATCH rtw-next v2 1/2] wifi: rtw88: move the bmc high queue decision to tx.c Luka Gejak
2026-10-21 12:43 ` [PATCH rtw-next v2 2/2] wifi: rtw88: sdio: limit the high queue to DTIM delivery Luka Gejak
2026-10-22 2:24 ` Ping-Ke Shih
2026-10-22 4:30 ` Luka Gejak
2026-10-22 4:33 ` Ping-Ke Shih
2026-10-22 2:20 ` [PATCH rtw-next v2 1/2] wifi: rtw88: move the bmc high queue decision to tx.c Ping-Ke Shih
2026-10-22 5:11 ` Luka Gejak
2026-10-23 21:34 ` Luka Gejak [this message]
2026-10-25 2:49 ` Ping-Ke Shih
2026-10-25 8:26 ` Luka Gejak
2026-10-27 1:19 ` Ping-Ke Shih
2026-10-27 5:22 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875b4e96891a2bf256ca1805140b57aeccee4aed@linux.dev \
--to=luka.gejak@linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.