From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Ping-Ke Shih" <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH rtw-next v2 2/2] wifi: rtw88: sdio: limit the high queue to DTIM delivery
Date: Thu, 22 Oct 2026 04:30:37 +0000 [thread overview]
Message-ID: <ea8ee18b36d7416c11ae4f1b4046aed087f87f1c@linux.dev> (raw)
In-Reply-To: <ea2137c603f146738f8db100e905060a@realtek.com>
October 22, 2026 at 4:24 AM, "Ping-Ke Shih" <pkshih@realtek.com> wrote:
>
> Luka Gejak <luka.gejak@linux.dev> wrote:
>
> >
> > In AP mode every broadcast and multicast (bmc) frame is sent through the
> > high queue, which the hardware only drains after a DTIM beacon. Only a
> > few frames leave per DTIM, so steady multicast traffic builds a backlog
> > that holds the TX pages the other queues need. Unicast traffic then
> > stalls for seconds and clients can no longer renew their DHCP lease.
> >
> > USB had the same problem and was fixed by commit c710c7c2e038 ("wifi:
> > rtw88: usb: route bmc frames via the high queue only for DTIM delivery")
> > and the two commits that followed it. Use the same rule for SDIO. A bmc
> > frame goes to the high queue only when mac80211 asks for DTIM delivery
> > because a station is dozing, the frame is ARP, EAPOL or DHCP, and the
> > budget allows it. All other bmc frames go out on their access category
> > queue.
> >
> I'd remove second paragraph since it just describes the patch 1/2 does.
>
Would you be willing to drop it your when applying?
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-10-22 4:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 12:43 [PATCH rtw-next v2 1/2] wifi: rtw88: move the bmc high queue decision to tx.c Luka Gejak
2026-10-21 12:43 ` [PATCH rtw-next v2 2/2] wifi: rtw88: sdio: limit the high queue to DTIM delivery Luka Gejak
2026-10-22 2:24 ` Ping-Ke Shih
2026-10-22 4:30 ` Luka Gejak [this message]
2026-10-22 4:33 ` Ping-Ke Shih
2026-10-22 2:20 ` [PATCH rtw-next v2 1/2] wifi: rtw88: move the bmc high queue decision to tx.c Ping-Ke Shih
2026-10-22 5:11 ` Luka Gejak
2026-10-23 21:34 ` Luka Gejak
2026-10-25 2:49 ` Ping-Ke Shih
2026-10-25 8:26 ` Luka Gejak
2026-10-27 1:19 ` Ping-Ke Shih
2026-10-27 5:22 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea8ee18b36d7416c11ae4f1b4046aed087f87f1c@linux.dev \
--to=luka.gejak@linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.