All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michael Walle" <mwalle@kernel.org>
Cc: "Pratyush Yadav" <pratyush@kernel.org>,
	 "Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	 "Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	 "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	 "Steam Lin" <STLin2@winbond.com>,
	<linux-mtd@lists.infradead.org>,  <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 10/17] mtd: spi-nor: Fix SWP for octal DTR chips
Date: Wed, 18 Nov 2026 15:25:05 +0100	[thread overview]
Message-ID: <875wxui5dq.fsf@bootlin.com> (raw)
In-Reply-To: <DMYC2B7I8C13.2UQIDHJKGBSP6@kernel.org> (Michael Walle's message of "Wed, 18 Nov 2026 13:25:08 +0100")

On 18/11/2026 at 13:25:08 +01, "Michael Walle" <mwalle@kernel.org> wrote:

> On Tue Oct 13, 2026 at 6:34 PM CEST, Miquel Raynal wrote:
>> During the recent rework of status registers handling, we mostly focused
>> on quad capable devices, partially skipping ODTR devices in our mental
>> model. It seems that many (if not all?) ODTR devices have no SR2 read
>> opcode and have other control mechanisms. Because of that, the current
>> support in swp.c is broken, because reading back the written value may
>> or may not lead to the expected result.
>
> Is this still the case with the recent fix for the .read_sr2 opcode
> from  Haibo Chen [1]?

While I believe his fix will prevent my case from happening, I would
still be in favour of keeping this patch. I should probably have wrote
that in the first place?

Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michael Walle" <mwalle@kernel.org>
Cc: "Pratyush Yadav" <pratyush@kernel.org>,
	 "Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	 "Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	 "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	 "Steam Lin" <STLin2@winbond.com>,
	<linux-mtd@lists.infradead.org>,  <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 10/17] mtd: spi-nor: Fix SWP for octal DTR chips
Date: Wed, 18 Nov 2026 15:25:05 +0100	[thread overview]
Message-ID: <875wxui5dq.fsf@bootlin.com> (raw)
In-Reply-To: <DMYC2B7I8C13.2UQIDHJKGBSP6@kernel.org> (Michael Walle's message of "Wed, 18 Nov 2026 13:25:08 +0100")

On 18/11/2026 at 13:25:08 +01, "Michael Walle" <mwalle@kernel.org> wrote:

> On Tue Oct 13, 2026 at 6:34 PM CEST, Miquel Raynal wrote:
>> During the recent rework of status registers handling, we mostly focused
>> on quad capable devices, partially skipping ODTR devices in our mental
>> model. It seems that many (if not all?) ODTR devices have no SR2 read
>> opcode and have other control mechanisms. Because of that, the current
>> support in swp.c is broken, because reading back the written value may
>> or may not lead to the expected result.
>
> Is this still the case with the recent fix for the .read_sr2 opcode
> from  Haibo Chen [1]?

While I believe his fix will prevent my case from happening, I would
still be in favour of keeping this patch. I should probably have wrote
that in the first place?

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-11-18 14:25 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 16:33 [PATCH v3 00/17] mtd: spi-nor: winbond: Add support for the W35TxxNW family Miquel Raynal
2026-10-13 16:33 ` Miquel Raynal
2026-10-13 16:33 ` [PATCH v3 01/17] mtd: spi-nor: Only switch to ODTR if the chip has a callback for it Miquel Raynal
2026-10-13 16:33   ` Miquel Raynal
2026-10-13 16:33 ` [PATCH v3 02/17] mtd: spi-nor: swp: Fix SR2 initialization Miquel Raynal
2026-10-13 16:33   ` Miquel Raynal
2026-10-13 16:33 ` [PATCH v3 03/17] mtd: spi-nor: Fix spacing between arguments Miquel Raynal
2026-10-13 16:33   ` Miquel Raynal
2026-10-13 16:33 ` [PATCH v3 04/17] mtd: spi-nor: Fix comment indentation to clarify the intent Miquel Raynal
2026-10-13 16:33   ` Miquel Raynal
2026-10-13 16:33 ` [PATCH v3 05/17] mtd: spi-nor: sfdp: Enhance a comment Miquel Raynal
2026-10-13 16:33   ` Miquel Raynal
2026-10-13 16:33 ` [PATCH v3 06/17] mtd: spi-nor: Fix the meaning of " Miquel Raynal
2026-10-13 16:33   ` Miquel Raynal
2026-10-13 16:33 ` [PATCH v3 07/17] mtd: spi-nor: Drop stale values Miquel Raynal
2026-10-13 16:33   ` Miquel Raynal
2026-10-13 16:33 ` [PATCH v3 08/17] mtd: spi-nor: Fix WRSR with ODTR chips Miquel Raynal
2026-10-13 16:33   ` Miquel Raynal
2026-10-13 16:51   ` sashiko-bot
2026-10-14  8:56     ` Miquel Raynal
2026-10-13 16:33 ` [PATCH v3 09/17] mtd: spi-nor: Allow configuring the actual number of dummy cycles Miquel Raynal
2026-10-13 16:33   ` Miquel Raynal
2026-10-13 16:49   ` sashiko-bot
2026-10-14  9:09     ` Miquel Raynal
2026-10-13 16:34 ` [PATCH v3 10/17] mtd: spi-nor: Fix SWP for octal DTR chips Miquel Raynal
2026-10-13 16:34   ` Miquel Raynal
2026-11-18 12:25   ` Michael Walle
2026-11-18 12:25     ` Michael Walle
2026-11-18 14:25     ` Miquel Raynal [this message]
2026-11-18 14:25       ` Miquel Raynal
2026-10-13 16:34 ` [PATCH v3 11/17] mtd: spi-nor: winbond: Prepare the introduction of W35TxxNW parts Miquel Raynal
2026-10-13 16:34   ` Miquel Raynal
2026-10-13 16:34 ` [PATCH v3 12/17] mtd: spi-nor: winbond: Add support for W35T64NW-C Miquel Raynal
2026-10-13 16:34   ` Miquel Raynal
2026-10-13 16:34 ` [PATCH v3 13/17] mtd: spi-nor: winbond: Add support for W35T12NW-C Miquel Raynal
2026-10-13 16:34   ` Miquel Raynal
2026-10-13 16:34 ` [PATCH v3 14/17] mtd: spi-nor: winbond: Add support for W35T25NW-C/E Miquel Raynal
2026-10-13 16:34   ` Miquel Raynal
2026-10-13 16:34 ` [PATCH v3 15/17] mtd: spi-nor: winbond: Add support for W35T51NW-C/E Miquel Raynal
2026-10-13 16:34   ` Miquel Raynal
2026-10-13 16:34 ` [PATCH v3 16/17] mtd: spi-nor: winbond: Add support for W35T01NW-C/E Miquel Raynal
2026-10-13 16:34   ` Miquel Raynal
2026-10-13 16:34 ` [PATCH v3 17/17] mtd: spi-nor: winbond: Add support for W35T02NW-C/E Miquel Raynal
2026-10-13 16:34   ` Miquel Raynal
2026-10-14  9:12 ` [PATCH v3 00/17] mtd: spi-nor: winbond: Add support for the W35TxxNW family Miquel Raynal
2026-10-14  9:12   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875wxui5dq.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=STLin2@winbond.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=takahiro.kuwano@infineon.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.