All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Dominique Martinet <dominique.martinet@atmark-techno.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Daisuke Mizobuchi <mizo@atmark-techno.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Steam Lin <stlin2@winbond.com>,
	linux-mtd@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/13] mtd: spinand: winbond: Generalize the KV OOB layout
Date: Tue, 17 Nov 2026 16:33:46 +0100	[thread overview]
Message-ID: <875wxvlbfp.fsf@bootlin.com> (raw)
In-Reply-To: <auT9takcaT1TWj0W@atmark-techno.com> (Dominique Martinet's message of "Sat, 31 Oct 2026 05:27:33 +0900")


>> +	unsigned int offset = mtd->oobsize / 2;
>> +	unsigned int num_sections = mtd->writesize / 512;
>
> Ah, I couldn't use oobsize for num_sections because of W25N01KV but
> using writesize makes sense as well as there's one section per 512 bytes
> chunk, and this works for all devices.
>
> Good cleanup!
>
> Reviewed-by: Dominique Martinet <dominique.martinet@atmark-techno.com>

Thanks a lot for the feedback!

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Dominique Martinet <dominique.martinet@atmark-techno.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Daisuke Mizobuchi <mizo@atmark-techno.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Steam Lin <stlin2@winbond.com>,
	linux-mtd@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/13] mtd: spinand: winbond: Generalize the KV OOB layout
Date: Tue, 17 Nov 2026 16:33:46 +0100	[thread overview]
Message-ID: <875wxvlbfp.fsf@bootlin.com> (raw)
In-Reply-To: <auT9takcaT1TWj0W@atmark-techno.com> (Dominique Martinet's message of "Sat, 31 Oct 2026 05:27:33 +0900")


>> +	unsigned int offset = mtd->oobsize / 2;
>> +	unsigned int num_sections = mtd->writesize / 512;
>
> Ah, I couldn't use oobsize for num_sections because of W25N01KV but
> using writesize makes sense as well as there's one section per 512 bytes
> chunk, and this works for all devices.
>
> Good cleanup!
>
> Reviewed-by: Dominique Martinet <dominique.martinet@atmark-techno.com>

Thanks a lot for the feedback!

Miquèl

  reply	other threads:[~2026-11-17 15:34 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 17:45 [PATCH 00/13] mtd: spinand winbond: Add support for W25NxxLV and W25NxxLW chips Miquel Raynal
2026-10-30 17:45 ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 01/13] mtd: spinand: winbond: Fix an OOB layout inconsistency with " Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 02/13] mtd: spinand: winbond: Generalize the KV OOB layout Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:51   ` sashiko-bot
2026-10-30 20:27   ` Dominique Martinet
2026-10-30 20:27     ` Dominique Martinet
2026-11-17 15:33     ` Miquel Raynal [this message]
2026-11-17 15:33       ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 03/13] mtd: spinand: winbond: Generalize the LW " Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:51   ` sashiko-bot
2026-10-30 17:45 ` [PATCH 04/13] mtd: spinand: winbond: Rename the ->set_cont_read() helper Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 05/13] mtd: spinand: winbond: Rename the ->ecc_get_status() helper Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 06/13] mtd: spinand: winbond: Add 1S_1S_1S continuous read variant Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 07/13] mtd: spinand: winbond: Add basic support for W25N02LV Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 08/13] mtd: spinand: winbond: Add basic support for W25N04LV Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 09/13] mtd: spinand: winbond: Add basic support for W25N02LW Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 10/13] mtd: spinand: winbond: Add continuous read support for W25N02LV Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 11/13] mtd: spinand: winbond: Add continuous read support for W25N04LV Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 12/13] mtd: spinand: winbond: Add continuous read support for W25N02LW Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:45 ` [PATCH 13/13] mtd: spinand: winbond: Add continuous read support for W25N04LW Miquel Raynal
2026-10-30 17:45   ` Miquel Raynal
2026-10-30 17:57   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875wxvlbfp.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=dominique.martinet@atmark-techno.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mizo@atmark-techno.com \
    --cc=richard@nod.at \
    --cc=stlin2@winbond.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.