From: Takashi Iwai <tiwai@suse.de>
To: Steven 'Steve' Kendall <skend@chromium.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ALSA: hda/cs8409: Fix for Dell Cirrus audio jack detect
Date: Wed, 16 Sep 2026 09:33:34 +0200 [thread overview]
Message-ID: <875x05lkfl.wl-tiwai@suse.de> (raw)
In-Reply-To: <87fqzan7jp.wl-tiwai@suse.de>
On Tue, 15 Sep 2026 12:16:42 +0200,
Takashi Iwai wrote:
>
> On Tue, 15 Sep 2026 04:11:38 +0200,
> Steven 'Steve' Kendall wrote:
> >
> > On some models like the Dell Inspiron 15 3520, jack
> > detection does not work. This patch switches to
> > delayed work to fix jack plug on Chrome OS.
> >
> > Assisted-by: LLM
> > Signed-off-by: Steven 'Steve' Kendall <skend@chromium.org>
>
> The code change looks acceptable, but the patch description gives too
> little information.
>
> And, should we apply it unconditionally all models with this code?
... also please check sashiko's review
https://sashiko.dev/#/patchset/20260915-fix-headphone-plug-cirrus-dell-v3-1-6dc555b00f61%40chromium.org
They aren't always correct but often give good hints.
thanks,
Takashi
next prev parent reply other threads:[~2026-09-16 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 2:11 [PATCH v3] ALSA: hda/cs8409: Fix for Dell Cirrus audio jack detect Steven 'Steve' Kendall
2026-09-15 10:16 ` Takashi Iwai
2026-09-16 7:33 ` Takashi Iwai [this message]
2026-09-21 21:00 ` Steven Kendall
2026-10-04 18:49 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x05lkfl.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=skend@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.