Re: [PATCH v3] ALSA: hda/cs8409: Fix for Dell Cirrus audio jack detect

[Takashi Iwai <tiwai@suse.de>]

On Mon, 21 Sep 2026 23:00:28 +0200,
Steven Kendall wrote:
> 
> > > The code change looks acceptable, but the patch description gives too
> > > little information.
> > >
> > > And, should we apply it unconditionally all models with this code?
> 
> I've submitted a v4 that only applies the delay to this specific model
> I've observed the issue on.
> 
> > ... also please check sashiko's review
> >   https://sashiko.dev/#/patchset/20260915-fix-headphone-plug-cirrus-dell-v3-1-6dc555b00f61%40chromium.org
> >
> > They aren't always correct but often give good hints.
> 
> I looked over the AI feedback and I'm not sure what the best action to
> take is. It seemed like it was kind of a broad criticism of delayed
> work in general, which already exists in the same file. Now that the
> patch only applies to one machine and I've tested on that one machine
> I'm more confident in the fix but I'm open to doing additional
> testing. Or if there's some tooling I should be using to make the
> abstract "timing issues" more observable I would love to learn more
> about that too.

The review to v4 showed about only the usage of cancel_work_*(),
and the suggestion sounds reasonable.  Those new cancel_work_*()
should be put before disabling i2c.

BTW, at the remove patch, maybe better to use disable_work*() variant
than cancel_work*().  The existing code is old and they were before
disable_*() was introduced (so they should be replaced, too).


thanks,

Takashi