All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH mvebu-dt64] arm64: dts: turris-mox: fix usb3 phys
@ 2026-07-07 21:08 Tomáš Macholda
  2026-08-09 10:43 ` Gregory CLEMENT
  0 siblings, 1 reply; 2+ messages in thread
From: Tomáš Macholda @ 2026-07-07 21:08 UTC (permalink / raw)
  To: Gregory Clement, Andrew Lunn, Sebastian Hesselbarth
  Cc: Marek Behún, linux-arm-kernel, devicetree,
	Tomáš Macholda

After commit 00e6d608fe80b0f6 ("arm64: dts: marvell: armada-37xx: swap
PHYs' order in USB3 controller node") swapped USB3 PHY order, USB
initialization breaks on Turris MOX.

This regression was exposed by commit 91ddf6f722084383 ("phy: marvell:
mvebu-a3700-utmi: fix incorrect USB2_PHY_CTRL register access") which
made USB2 devices not work at all.

Fix the issue by explicitly adding all USB3 PHYs and PHY names to
Turris MOX device-tree.

Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox")
Signed-off-by: Tomáš Macholda <tomas.macholda@nic.cz>
---
 arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
index f4d73c8b1a6d..bd00e7df87c6 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
@@ -290,7 +290,8 @@ connector {
 
 &usb3 {
 	status = "okay";
-	phys = <&comphy2 0>;
+	phys = <&usb2_utmi_otg_phy>, <&comphy2 0>;
+	phy-names = "usb2-phy", "usb3-phy";
 };
 
 &mdio {
-- 
2.54.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH mvebu-dt64] arm64: dts: turris-mox: fix usb3 phys
  2026-07-07 21:08 [PATCH mvebu-dt64] arm64: dts: turris-mox: fix usb3 phys Tomáš Macholda
@ 2026-08-09 10:43 ` Gregory CLEMENT
  0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2026-08-09 10:43 UTC (permalink / raw)
  To: Tomáš Macholda, Andrew Lunn, Sebastian Hesselbarth
  Cc: Marek Behún, linux-arm-kernel, devicetree,
	Tomáš Macholda

Hi Tomáš Macholda,

> After commit 00e6d608fe80b0f6 ("arm64: dts: marvell: armada-37xx: swap
> PHYs' order in USB3 controller node") swapped USB3 PHY order, USB
> initialization breaks on Turris MOX.
>
> This regression was exposed by commit 91ddf6f722084383 ("phy: marvell:
> mvebu-a3700-utmi: fix incorrect USB2_PHY_CTRL register access") which
> made USB2 devices not work at all.
>
> Fix the issue by explicitly adding all USB3 PHYs and PHY names to
> Turris MOX device-tree.
>
> Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox")
> Signed-off-by: Tomáš Macholda <tomas.macholda@nic.cz>

Applied on mvebu/dt64

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> index f4d73c8b1a6d..bd00e7df87c6 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> @@ -290,7 +290,8 @@ connector {
>  
>  &usb3 {
>  	status = "okay";
> -	phys = <&comphy2 0>;
> +	phys = <&usb2_utmi_otg_phy>, <&comphy2 0>;
> +	phy-names = "usb2-phy", "usb3-phy";
>  };
>  
>  &mdio {
> -- 
> 2.54.0
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-09 10:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-07 21:08 [PATCH mvebu-dt64] arm64: dts: turris-mox: fix usb3 phys Tomáš Macholda
2026-08-09 10:43 ` Gregory CLEMENT

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.