From: Cornelia Huck <cohuck@redhat.com>
To: eric.auger@redhat.com,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/3] arm: handle demuxed ID registers
Date: Thu, 02 Apr 2026 16:55:44 +0200 [thread overview]
Message-ID: <875x69e7in.fsf@redhat.com> (raw)
In-Reply-To: <b5315132-bedb-499a-9cf6-83132e8559a3@redhat.com>
On Wed, Apr 01 2026, Eric Auger <eric.auger@redhat.com> wrote:
> On 4/1/26 10:17 AM, Cornelia Huck wrote:
>> On Thu, Feb 05 2026, Richard Henderson <richard.henderson@linaro.org> wrote:
>>> I'm not keen on this. Surely we don't expect all multiplexed ID registers to have the
>>> same number of sub-registers? A rectangular matrix isn't a great representation. Also,
>>> you're wasting a hole in idregs[] with CSSIDR_EL1_IDX.
>>>
>>> Why not just have the N sub-registers occupy N entries within the regular idregs[]?
>>> Something like
>>>
>>> #define DEF_MUX(NAME, OP0, OP1, CRN, CRM, OP2, NUM) \
>>> NAME##_DEMUX_IDX, \
>>> NAME##_DEMUX_LAST = NAME##_DEMUX_IDX + NUM - 1,
>>>
>>> #define SET_IDREG_DEMUX(ISAR, REG, INDEX, VALUE) \
>>> ({ \
>>> ARMISARegisters *i_ = (ISAR); \
>>> i_->idregs_demux[REG ## _EL1_DEMUX_IDX + INDEX] = VALUE; \
> I guess we would use regular i_-> idregs[] here, right?
Yes.
>
> Thanks
>
> Eric
>>> })
>>>
>>> etc.
>> Yeah, I was not overly excited about my solution, either. I'll go and
>> play with this, thanks.
>>
>>
next prev parent reply other threads:[~2026-04-02 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 13:32 [PATCH v2 0/3] arm: demuxed ID registers (CCSIDR_EL1) Cornelia Huck
2026-02-04 13:32 ` [PATCH v2 1/3] arm: handle demuxed ID registers Cornelia Huck
2026-02-05 3:24 ` Richard Henderson
2026-04-01 8:17 ` Cornelia Huck
2026-04-01 16:26 ` Eric Auger
2026-04-02 14:55 ` Cornelia Huck [this message]
2026-02-04 13:32 ` [PATCH v2 2/3] arm: handle CCSIDR_EL1 as a demuxed register Cornelia Huck
2026-04-01 16:46 ` Eric Auger
2026-04-02 15:04 ` Cornelia Huck
2026-02-04 13:32 ` [PATCH v2 3/3] arm/kvm: get demuxed ID registers from kvm Cornelia Huck
2026-04-01 17:00 ` Eric Auger
2026-04-02 15:19 ` Cornelia Huck
2026-02-05 11:52 ` [PATCH v2 0/3] arm: demuxed ID registers (CCSIDR_EL1) Peter Maydell
2026-02-05 16:50 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x69e7in.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.