From: Thomas Gleixner <tglx@linutronix.de>
To: Michael Jeanson <mjeanson@efficios.com>,
Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Wei Liu <wei.liu@kernel.org>
Subject: Re: [patch 00/11] rseq: Optimize exit to user space
Date: Tue, 19 Aug 2025 01:43:57 +0200 [thread overview]
Message-ID: <875xekxkjm.ffs@tglx> (raw)
In-Reply-To: <f5f862e2-5ce9-4d49-970f-b480cb3e7ba2@efficios.com>
On Mon, Aug 18 2025 at 17:29, Michael Jeanson wrote:
> On 2025-08-18 16:21, Thomas Gleixner wrote:
>> That looks about right. Can you reset the branch to
>>
>> commit 85b61b265635 ("rseq: Expose stats")
>>
>> which is just adding primitive stats on top of the current mainline
>> code, and provide numbers for that too?
>>
>> That gives you 'notify: , cpuid:, fixup:' numbers, which are not 1:1
>> mappable to the final ones, but that should give some interesting
>> insight.
>
> For amd64 kernel and userspace.
>
> Before:
>
> notify: 12467
> fixup: 12467
> cpuid: 12467
>
>
> After:
>
> notify: 123669528
> fixup: 123669528
> cpuid: 123669528
That's insane compared to this:
> exit: 229294046
> signal: 11
> slowp: 4570
> ids: 615950
> cs: 2493682
> clear: 194637
> fixup: 2299044
You can assume that the number of exits (to user) is roughly the same,
i.e. ~23M, so 12M (> 50%) take the TIF_NOTIFY dance on the way out and
most of them for no good reason.
While with the rework only 4.5K go into the NOTIFY slow path and 2.5M
(10 %) do the critical section evaluation and 600k (~ 3%) update CPU/MM
CID.
No suprise that Jens is seeing this in his profiles...
Thanks,
tglx
next prev parent reply other threads:[~2025-08-18 23:44 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 16:29 [patch 00/11] rseq: Optimize exit to user space Thomas Gleixner
2025-08-13 16:29 ` [patch 01/11] rseq: Avoid pointless evaluation in __rseq_notify_resume() Thomas Gleixner
2025-08-20 14:23 ` Mathieu Desnoyers
2025-08-13 16:29 ` [patch 02/11] rseq: Condense the inline stubs Thomas Gleixner
2025-08-20 14:24 ` Mathieu Desnoyers
2025-08-13 16:29 ` [patch 03/11] rseq: Rename rseq_syscall() to rseq_debug_syscall_exit() Thomas Gleixner
2025-08-20 14:25 ` Mathieu Desnoyers
2025-08-13 16:29 ` [patch 04/11] rseq: Replace the pointless event mask bit fiddling Thomas Gleixner
2025-08-13 16:29 ` [patch 05/11] rseq: Optimize the signal delivery path Thomas Gleixner
2025-08-13 16:29 ` [patch 06/11] rseq: Optimize exit to user space further Thomas Gleixner
2025-08-13 16:29 ` [patch 07/11] entry: Cleanup header Thomas Gleixner
2025-08-13 17:09 ` Giorgi Tchankvetadze
2025-08-13 21:30 ` Thomas Gleixner
2025-08-13 16:29 ` [patch 08/11] entry: Distinguish between syscall and interrupt exit Thomas Gleixner
2025-08-13 16:29 ` [patch 09/11] entry: Provide exit_to_user_notify_resume() Thomas Gleixner
2025-08-13 16:29 ` [patch 10/11] rseq: Skip fixup when returning from a syscall Thomas Gleixner
2025-08-14 8:54 ` Peter Zijlstra
2025-08-14 13:24 ` Thomas Gleixner
2025-08-13 16:29 ` [patch 11/11] rseq: Convert to masked user access where applicable Thomas Gleixner
2025-08-13 17:45 ` [patch 00/11] rseq: Optimize exit to user space Jens Axboe
2025-08-13 21:32 ` Thomas Gleixner
2025-08-13 21:36 ` Jens Axboe
2025-08-13 22:08 ` Thomas Gleixner
2025-08-17 21:23 ` Thomas Gleixner
2025-08-18 14:00 ` BUG: rseq selftests and librseq vs. glibc fail Thomas Gleixner
2025-08-18 14:15 ` Florian Weimer
2025-08-18 17:13 ` Thomas Gleixner
2025-08-18 19:33 ` Florian Weimer
2025-08-18 19:46 ` Sean Christopherson
2025-08-18 19:55 ` Florian Weimer
2025-08-18 20:27 ` Sean Christopherson
2025-08-18 23:54 ` Thomas Gleixner
2025-08-19 0:28 ` Sean Christopherson
2025-08-19 6:18 ` Florian Weimer
2025-08-29 18:44 ` Prakash Sangappa
2025-08-29 18:50 ` Mathieu Desnoyers
2025-09-01 19:30 ` Prakash Sangappa
2025-08-18 17:38 ` [patch 00/11] rseq: Optimize exit to user space Michael Jeanson
2025-08-18 20:21 ` Thomas Gleixner
2025-08-18 21:29 ` Michael Jeanson
2025-08-18 23:43 ` Thomas Gleixner [this message]
2025-08-20 14:27 ` Mathieu Desnoyers
2025-08-20 14:10 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xekxkjm.ffs@tglx \
--to=tglx@linutronix.de \
--cc=axboe@kernel.dk \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mjeanson@efficios.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.