From: Thomas Gleixner <tglx@linutronix.de>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Michael Jeanson <mjeanson@efficios.com>,
Peter Zijlstra <peterz@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Wei Liu <wei.liu@kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [patch 07/11] entry: Cleanup header
Date: Wed, 13 Aug 2025 23:30:18 +0200 [thread overview]
Message-ID: <87ecte7vv9.ffs@tglx> (raw)
In-Reply-To: <CAE7dp2pxxKWdNJkwZZDw2GmR6vH8YVMGcTm55u1pxVygaeNydw@mail.gmail.com>
On Wed, Aug 13 2025 at 21:09, Giorgi Tchankvetadze wrote:
Please do not top-post and reply inline so there is context:
https://people.kernel.org/tglx/notes-about-netiquette
> Typo in kernel-doc:
> In irq-entry-common.h the doc line reads Pointer to currents pt_regs —
> should be Pointer to current's pt_regs (or Pointer to current->pt_regs
> depending on local style).
Good point.
> Stray blank/trailing whitespace:
> In entry-common.h there is an extra blank line inserted after the
> ARCH_SYSCALL_WORK_ENTER) macro continuation — remove the stray blank
> to avoid style/noise.
No.
>> @@ -37,6 +37,7 @@
>> SYSCALL_WORK_SYSCALL_AUDIT | \
>> SYSCALL_WORK_SYSCALL_USER_DISPATCH | \
>> ARCH_SYSCALL_WORK_ENTER)
There is no continuation of the SYSCALL_WORK_ENTER macro.
>> +
And this is an empty new line to visually seperate SYSCALL_WORK_ENTER
from SYSCALL_WORK_EXIT.
>> #define SYSCALL_WORK_EXIT (SYSCALL_WORK_SYSCALL_TRACEPOINT | \
No?
Thanks,
tglx
next prev parent reply other threads:[~2025-08-13 21:30 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 16:29 [patch 00/11] rseq: Optimize exit to user space Thomas Gleixner
2025-08-13 16:29 ` [patch 01/11] rseq: Avoid pointless evaluation in __rseq_notify_resume() Thomas Gleixner
2025-08-20 14:23 ` Mathieu Desnoyers
2025-08-13 16:29 ` [patch 02/11] rseq: Condense the inline stubs Thomas Gleixner
2025-08-20 14:24 ` Mathieu Desnoyers
2025-08-13 16:29 ` [patch 03/11] rseq: Rename rseq_syscall() to rseq_debug_syscall_exit() Thomas Gleixner
2025-08-20 14:25 ` Mathieu Desnoyers
2025-08-13 16:29 ` [patch 04/11] rseq: Replace the pointless event mask bit fiddling Thomas Gleixner
2025-08-13 16:29 ` [patch 05/11] rseq: Optimize the signal delivery path Thomas Gleixner
2025-08-13 16:29 ` [patch 06/11] rseq: Optimize exit to user space further Thomas Gleixner
2025-08-13 16:29 ` [patch 07/11] entry: Cleanup header Thomas Gleixner
2025-08-13 17:09 ` Giorgi Tchankvetadze
2025-08-13 21:30 ` Thomas Gleixner [this message]
2025-08-13 16:29 ` [patch 08/11] entry: Distinguish between syscall and interrupt exit Thomas Gleixner
2025-08-13 16:29 ` [patch 09/11] entry: Provide exit_to_user_notify_resume() Thomas Gleixner
2025-08-13 16:29 ` [patch 10/11] rseq: Skip fixup when returning from a syscall Thomas Gleixner
2025-08-14 8:54 ` Peter Zijlstra
2025-08-14 13:24 ` Thomas Gleixner
2025-08-13 16:29 ` [patch 11/11] rseq: Convert to masked user access where applicable Thomas Gleixner
2025-08-13 17:45 ` [patch 00/11] rseq: Optimize exit to user space Jens Axboe
2025-08-13 21:32 ` Thomas Gleixner
2025-08-13 21:36 ` Jens Axboe
2025-08-13 22:08 ` Thomas Gleixner
2025-08-17 21:23 ` Thomas Gleixner
2025-08-18 14:00 ` BUG: rseq selftests and librseq vs. glibc fail Thomas Gleixner
2025-08-18 14:15 ` Florian Weimer
2025-08-18 17:13 ` Thomas Gleixner
2025-08-18 19:33 ` Florian Weimer
2025-08-18 19:46 ` Sean Christopherson
2025-08-18 19:55 ` Florian Weimer
2025-08-18 20:27 ` Sean Christopherson
2025-08-18 23:54 ` Thomas Gleixner
2025-08-19 0:28 ` Sean Christopherson
2025-08-19 6:18 ` Florian Weimer
2025-08-29 18:44 ` Prakash Sangappa
2025-08-29 18:50 ` Mathieu Desnoyers
2025-09-01 19:30 ` Prakash Sangappa
2025-08-18 17:38 ` [patch 00/11] rseq: Optimize exit to user space Michael Jeanson
2025-08-18 20:21 ` Thomas Gleixner
2025-08-18 21:29 ` Michael Jeanson
2025-08-18 23:43 ` Thomas Gleixner
2025-08-20 14:27 ` Mathieu Desnoyers
2025-08-20 14:10 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecte7vv9.ffs@tglx \
--to=tglx@linutronix.de \
--cc=axboe@kernel.dk \
--cc=boqun.feng@gmail.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mjeanson@efficios.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.