* [PATCH] linux-user: Add missing mmap include
@ 2024-10-28 18:18 Patrick Leis
2024-11-12 15:50 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Patrick Leis @ 2024-10-28 18:18 UTC (permalink / raw)
To: laurent, peter.maydell; +Cc: qemu-devel, Peter Foley, Patrick Leis
From: Peter Foley <pefoley@google.com>
error: use of undeclared identifier 'MAP_FIXED_NOREPLACE'
Signed-off-by: Patrick Leis <venture@google.com>
Signed-off-by: Peter Foley <pefoley@google.com>
---
linux-user/user-mmap.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/user-mmap.h b/linux-user/user-mmap.h
index b94bcdcf83..de769f9253 100644
--- a/linux-user/user-mmap.h
+++ b/linux-user/user-mmap.h
@@ -18,6 +18,8 @@
#ifndef LINUX_USER_USER_MMAP_H
#define LINUX_USER_USER_MMAP_H
+#include "linux/mman.h"
+
/*
* Guest parameters for the ADDR_COMPAT_LAYOUT personality
* (at present this is the only layout supported by QEMU).
--
2.47.0.163.g1226f6d8fa-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] linux-user: Add missing mmap include
2024-10-28 18:18 [PATCH] linux-user: Add missing mmap include Patrick Leis
@ 2024-11-12 15:50 ` Richard Henderson
2024-11-12 16:35 ` Alex Bennée
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2024-11-12 15:50 UTC (permalink / raw)
To: Patrick Leis, laurent, peter.maydell; +Cc: qemu-devel, Peter Foley
On 10/28/24 11:18, Patrick Leis wrote:
> From: Peter Foley <pefoley@google.com>
>
> error: use of undeclared identifier 'MAP_FIXED_NOREPLACE'
>
> Signed-off-by: Patrick Leis <venture@google.com>
> Signed-off-by: Peter Foley <pefoley@google.com>
> ---
> linux-user/user-mmap.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/linux-user/user-mmap.h b/linux-user/user-mmap.h
> index b94bcdcf83..de769f9253 100644
> --- a/linux-user/user-mmap.h
> +++ b/linux-user/user-mmap.h
> @@ -18,6 +18,8 @@
> #ifndef LINUX_USER_USER_MMAP_H
> #define LINUX_USER_USER_MMAP_H
>
> +#include "linux/mman.h"
> +
> /*
> * Guest parameters for the ADDR_COMPAT_LAYOUT personality
> * (at present this is the only layout supported by QEMU).
In what context does this appear?
Both glibc and musl define this in <sys/mmap.h>.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] linux-user: Add missing mmap include
2024-11-12 15:50 ` Richard Henderson
@ 2024-11-12 16:35 ` Alex Bennée
0 siblings, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2024-11-12 16:35 UTC (permalink / raw)
To: Richard Henderson
Cc: Patrick Leis, laurent, peter.maydell, qemu-devel, Peter Foley
Richard Henderson <richard.henderson@linaro.org> writes:
> On 10/28/24 11:18, Patrick Leis wrote:
>> From: Peter Foley <pefoley@google.com>
>> error: use of undeclared identifier 'MAP_FIXED_NOREPLACE'
>> Signed-off-by: Patrick Leis <venture@google.com>
>> Signed-off-by: Peter Foley <pefoley@google.com>
>> ---
>> linux-user/user-mmap.h | 2 ++
>> 1 file changed, 2 insertions(+)
>> diff --git a/linux-user/user-mmap.h b/linux-user/user-mmap.h
>> index b94bcdcf83..de769f9253 100644
>> --- a/linux-user/user-mmap.h
>> +++ b/linux-user/user-mmap.h
>> @@ -18,6 +18,8 @@
>> #ifndef LINUX_USER_USER_MMAP_H
>> #define LINUX_USER_USER_MMAP_H
>> +#include "linux/mman.h"
>> +
>> /*
>> * Guest parameters for the ADDR_COMPAT_LAYOUT personality
>> * (at present this is the only layout supported by QEMU).
>
> In what context does this appear?
> Both glibc and musl define this in <sys/mmap.h>.
I'm going to take a wild guess it's bionic:
🕙16:33:53 alex@draig:bionic.git on main
➜ git grep MAP_FIXED_NOREPLACE
libc/kernel/uapi/asm-generic/mman-common.h:#define MAP_FIXED_NOREPLACE 0x100000
>
>
> r~
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-12 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-28 18:18 [PATCH] linux-user: Add missing mmap include Patrick Leis
2024-11-12 15:50 ` Richard Henderson
2024-11-12 16:35 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.