All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: kan.liang@linux.intel.com, peterz@infradead.org,
	mingo@redhat.com, linux-kernel@vger.kernel.org
Cc: Kan Liang <kan.liang@linux.intel.com>,
	Oliver Sang <oliver.sang@intel.com>,
	Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Subject: Re: [PATCH 1/2] perf/x86/rapl: Move the pmu allocation out of CPU hotplug
Date: Tue, 08 Oct 2024 18:33:14 +0200	[thread overview]
Message-ID: <875xq2tv05.ffs@tglx> (raw)
In-Reply-To: <20240913171033.2144124-1-kan.liang@linux.intel.com>

On Fri, Sep 13 2024 at 10:10, kan liang wrote:
> +static void __init init_rapl_pmu(void)
> +{
> +	struct rapl_pmu *pmu;
> +	s32 rapl_pmu_idx;
> +	int cpu;
> +
> +	cpus_read_lock();
> +
> +	for_each_cpu(cpu, cpu_online_mask) {

How is that supposed to work, when not all CPUs are online when
init_rapl_pmus() is invoked?

Thanks,

        tglx

  parent reply	other threads:[~2024-10-08 16:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 17:10 [PATCH 1/2] perf/x86/rapl: Move the pmu allocation out of CPU hotplug kan.liang
2024-09-13 17:10 ` [PATCH 2/2] perf/x86/rapl: Clean up cpumask and hotplug kan.liang
2024-10-08 16:33 ` Thomas Gleixner [this message]
2024-10-08 20:10   ` [PATCH 1/2] perf/x86/rapl: Move the pmu allocation out of CPU hotplug Liang, Kan
2024-10-08 20:23     ` Thomas Gleixner
2024-10-08 20:36       ` Thomas Gleixner
2024-10-08 21:05         ` Liang, Kan
2024-10-08 22:38           ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xq2tv05.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=Dhananjay.Ugwekar@amd.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oliver.sang@intel.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.