From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, corbet@lwn.net
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 1/5] net: docs: add missing features that can have stats
Date: Tue, 04 Jun 2024 15:19:43 -0700 [thread overview]
Message-ID: <875xuocpvk.fsf@nvidia.com> (raw)
In-Reply-To: <20240604221327.299184-2-jesse.brandeburg@intel.com> (Jesse Brandeburg's message of "Tue, 4 Jun 2024 15:13:21 -0700")
On Tue, 04 Jun, 2024 15:13:21 -0700 Jesse Brandeburg <jesse.brandeburg@intel.com> wrote:
> While trying to figure out ethtool -I | --include-statistics, I noticed
> some docs got missed when implementing commit 0e9c127729be ("ethtool:
> add interface to read Tx hardware timestamping statistics").
>
> Fix up the docs to match the kernel code, and while there, sort them in
> alphabetical order.
>
> Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> I didn't add a Fixes: tag because this is not an urgent kind of fix that
> should require backports.
> ---
> Documentation/networking/statistics.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/networking/statistics.rst b/Documentation/networking/statistics.rst
> index 75e017dfa825..22503a90e369 100644
> --- a/Documentation/networking/statistics.rst
> +++ b/Documentation/networking/statistics.rst
> @@ -184,9 +184,11 @@ Protocol-related statistics can be requested in get commands by setting
> the `ETHTOOL_FLAG_STATS` flag in `ETHTOOL_A_HEADER_FLAGS`. Currently
> statistics are supported in the following commands:
>
> - - `ETHTOOL_MSG_PAUSE_GET`
> - `ETHTOOL_MSG_FEC_GET`
> + - 'ETHTOOL_MSG_LINKSTATE_GET'
> - `ETHTOOL_MSG_MM_GET`
> + - `ETHTOOL_MSG_PAUSE_GET`
> + - 'ETHTOOL_MSG_TSINFO_GET'
>
> debugfs
> -------
Thanks for catching this.
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
corbet@lwn.net, linux-doc@vger.kernel.org,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH iwl-next v1 1/5] net: docs: add missing features that can have stats
Date: Tue, 04 Jun 2024 15:19:43 -0700 [thread overview]
Message-ID: <875xuocpvk.fsf@nvidia.com> (raw)
In-Reply-To: <20240604221327.299184-2-jesse.brandeburg@intel.com> (Jesse Brandeburg's message of "Tue, 4 Jun 2024 15:13:21 -0700")
On Tue, 04 Jun, 2024 15:13:21 -0700 Jesse Brandeburg <jesse.brandeburg@intel.com> wrote:
> While trying to figure out ethtool -I | --include-statistics, I noticed
> some docs got missed when implementing commit 0e9c127729be ("ethtool:
> add interface to read Tx hardware timestamping statistics").
>
> Fix up the docs to match the kernel code, and while there, sort them in
> alphabetical order.
>
> Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> I didn't add a Fixes: tag because this is not an urgent kind of fix that
> should require backports.
> ---
> Documentation/networking/statistics.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/networking/statistics.rst b/Documentation/networking/statistics.rst
> index 75e017dfa825..22503a90e369 100644
> --- a/Documentation/networking/statistics.rst
> +++ b/Documentation/networking/statistics.rst
> @@ -184,9 +184,11 @@ Protocol-related statistics can be requested in get commands by setting
> the `ETHTOOL_FLAG_STATS` flag in `ETHTOOL_A_HEADER_FLAGS`. Currently
> statistics are supported in the following commands:
>
> - - `ETHTOOL_MSG_PAUSE_GET`
> - `ETHTOOL_MSG_FEC_GET`
> + - 'ETHTOOL_MSG_LINKSTATE_GET'
> - `ETHTOOL_MSG_MM_GET`
> + - `ETHTOOL_MSG_PAUSE_GET`
> + - 'ETHTOOL_MSG_TSINFO_GET'
>
> debugfs
> -------
Thanks for catching this.
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
next prev parent reply other threads:[~2024-06-04 22:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 22:13 [Intel-wired-lan] [PATCH iwl-next v1 0/5] ice: add standard stats Jesse Brandeburg
2024-06-04 22:13 ` Jesse Brandeburg
2024-06-04 22:13 ` [Intel-wired-lan] [PATCH iwl-next v1 1/5] net: docs: add missing features that can have stats Jesse Brandeburg
2024-06-04 22:13 ` Jesse Brandeburg
2024-06-04 22:19 ` Rahul Rameshbabu [this message]
2024-06-04 22:19 ` Rahul Rameshbabu
2024-06-06 0:48 ` [Intel-wired-lan] " Jakub Kicinski
2024-06-06 0:48 ` Jakub Kicinski
2024-06-06 16:28 ` [Intel-wired-lan] " Jesse Brandeburg
2024-06-06 16:28 ` Jesse Brandeburg
2024-06-06 16:56 ` [Intel-wired-lan] " Jacob Keller
2024-06-06 16:56 ` Jacob Keller
2024-06-04 22:13 ` [Intel-wired-lan] [PATCH iwl-next v1 2/5] ice: implement ethtool standard stats Jesse Brandeburg
2024-06-04 22:13 ` Jesse Brandeburg
2024-06-04 22:13 ` [Intel-wired-lan] [PATCH iwl-next v1 3/5] ice: add tracking of good transmit timestamps Jesse Brandeburg
2024-06-04 22:13 ` Jesse Brandeburg
2024-06-04 22:13 ` [Intel-wired-lan] [PATCH iwl-next v1 4/5] ice: implement transmit hardware timestamp statistics Jesse Brandeburg
2024-06-04 22:13 ` Jesse Brandeburg
2024-06-06 9:42 ` [Intel-wired-lan] " Hariprasad Kelam
2024-06-06 9:42 ` Hariprasad Kelam
2024-06-04 22:13 ` [Intel-wired-lan] [PATCH iwl-next v1 5/5] ice: refactor to use helpers Jesse Brandeburg
2024-06-04 22:13 ` Jesse Brandeburg
2024-06-05 4:01 ` [Intel-wired-lan] " Przemek Kitszel
2024-06-05 4:01 ` Przemek Kitszel
2024-06-06 0:50 ` [Intel-wired-lan] [PATCH iwl-next v1 0/5] ice: add standard stats Jakub Kicinski
2024-06-06 0:50 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xuocpvk.fsf@nvidia.com \
--to=rrameshbabu@nvidia.com \
--cc=corbet@lwn.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.