From: Jani Nikula <jani.nikula@linux.intel.com>
To: Gustavo Sousa <gustavo.sousa@intel.com>,
Mika Kahola <mika.kahola@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: imre.deak@intel.com, Mika Kahola <mika.kahola@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/display: Move port clock calculation
Date: Wed, 15 May 2024 16:59:11 +0300 [thread overview]
Message-ID: <875xvfch1s.fsf@intel.com> (raw)
In-Reply-To: <171577993817.27300.2440039459653683149@gjsousa-mobl2>
On Wed, 15 May 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Quoting Gustavo Sousa (2024-05-15 10:23:54-03:00)
>>Quoting Mika Kahola (2024-05-15 03:45:23-03:00)
>>>As a preparation to remove .clock member from pll state
>>>structure, let's move the port clock calculation on better
>>>location
>
> Ah... Also, I noticed that we are not simply moving the implementation
> of port calculation functions with this patch. We are also replacing
> usage of the "clock" members with function calls. I think the message
> subject and body should be reworded.
No, code movement is one patch, replacing .clock usage with function
calls is another patch, and removing .clock is yet another patch.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-05-15 13:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 6:45 [PATCH 1/2] drm/i915/display: Move port clock calculation Mika Kahola
2024-05-15 6:45 ` [PATCH 2/2] drm/i915/display: Remove .clock from pll state structure Mika Kahola
2024-05-15 13:28 ` Gustavo Sousa
2024-05-16 8:16 ` Kahola, Mika
2024-05-15 7:36 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/display: Move port clock calculation Patchwork
2024-05-15 7:36 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-15 7:41 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-15 13:23 ` [PATCH 1/2] " Gustavo Sousa
2024-05-15 13:32 ` Gustavo Sousa
2024-05-15 13:59 ` Jani Nikula [this message]
2024-05-15 14:39 ` Gustavo Sousa
2024-05-16 10:55 ` Kahola, Mika
2024-05-15 15:29 ` ✗ Fi.CI.IGT: failure for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xvfch1s.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=gustavo.sousa@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.