All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <ku920601@realtek.com>,  <kuba@kernel.org>,
	<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH wireless] wifi: rtw89: coex: fix configuration for shared antenna for 8922A
Date: Thu, 14 Mar 2024 10:33:29 +0200	[thread overview]
Message-ID: <875xxpfc12.fsf@kernel.org> (raw)
In-Reply-To: <20240309001348.9906-1-pkshih@realtek.com> (Ping-Ke Shih's message of "Sat, 9 Mar 2024 08:13:48 +0800")

Ping-Ke Shih <pkshih@realtek.com> writes:

> WiFi 2x2 + BT combo cards can be two or three physical antenna. For two
> antenna case, one antenna is shared by WiFi and BT, and different
> configuration should be applied. Fix the typo.
>
> This problem was found by Coccicheck, and actually that is a typo instead:
>   drivers/net/wireless/realtek/rtw89/rtw8922a.c:2235:2-4:
>     WARNING: possible condition with no effect (if == else)
>
> Fixes: 652c9642eda6 ("wifi: rtw89: coex: add init_info H2C command format version 7")
> Closes: https://lore.kernel.org/linux-wireless/170992024446.15593.2682606960737891240.git-patchwork-notify@kernel.org/T/#m074885bdbd91071c7d1771f08917831d9f89d95a

BTW for Closes and Link tags it's better to use a direct lore link with
Message-Id:

    Closes: https://lore.kernel.org/linux-wireless/20240308074539.04512f66@kernel.org/

The benefits are:

* as the Message-Id is in the link, the mail can be found even if
  lore.kernel.org would go away

* it's shorter

* regzbot uses the Message-Id to close the issues

In lore you can get the URL from "permalink" link. I changed the link
during commit, so no need to resend.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      parent reply	other threads:[~2024-03-14  8:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-09  0:13 [PATCH wireless] wifi: rtw89: coex: fix configuration for shared antenna for 8922A Ping-Ke Shih
2024-03-14  8:26 ` [wireless] " Kalle Valo
2024-03-14  8:33 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xxpfc12.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ku920601@realtek.com \
    --cc=kuba@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.