[PATCH wireless] wifi: rtw89: coex: fix configuration for shared antenna for 8922A

[PATCH wireless] wifi: rtw89: coex: fix configuration for shared antenna for 8922A

[Ping-Ke Shih]

WiFi 2x2 + BT combo cards can be two or three physical antenna. For two
antenna case, one antenna is shared by WiFi and BT, and different
configuration should be applied. Fix the typo.

This problem was found by Coccicheck, and actually that is a typo instead:
  drivers/net/wireless/realtek/rtw89/rtw8922a.c:2235:2-4:
    WARNING: possible condition with no effect (if == else)

Fixes: 652c9642eda6 ("wifi: rtw89: coex: add init_info H2C command format version 7")
Closes: https://lore.kernel.org/linux-wireless/170992024446.15593.2682606960737891240.git-patchwork-notify@kernel.org/T/#m074885bdbd91071c7d1771f08917831d9f89d95a
Cc: Ching-Te Ku <ku920601@realtek.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/rtw8922a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/rtw8922a.c b/drivers/net/wireless/realtek/rtw89/rtw8922a.c
index 367459bd1345..708132d5be2a 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8922a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8922a.c
@@ -2233,7 +2233,7 @@ static void rtw8922a_btc_init_cfg(struct rtw89_dev *rtwdev)
 		 * Shared-Ant && BTG-path:WL mask(0x55f), others:WL THRU(0x5ff)
 		 */
 		if (btc->ant_type == BTC_ANT_SHARED && btc->btg_pos == path)
-			rtw8922a_set_trx_mask(rtwdev, path, BTC_BT_TX_GROUP, 0x5ff);
+			rtw8922a_set_trx_mask(rtwdev, path, BTC_BT_TX_GROUP, 0x55f);
 		else
 			rtw8922a_set_trx_mask(rtwdev, path, BTC_BT_TX_GROUP, 0x5ff);
 
-- 
2.25.1

Re: [wireless] wifi: rtw89: coex: fix configuration for shared antenna for 8922A

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> wrote:

> WiFi 2x2 + BT combo cards can be two or three physical antenna. For two
> antenna case, one antenna is shared by WiFi and BT, and different
> configuration should be applied. Fix the typo.
> 
> This problem was found by Coccicheck, and actually that is a typo instead:
> 
>   rtw8922a.c:2235:2-4: WARNING: possible condition with no effect (if == else)
> 
> Fixes: 652c9642eda6 ("wifi: rtw89: coex: add init_info H2C command format version 7")
> Closes: https://lore.kernel.org/linux-wireless/20240308074539.04512f66@kernel.org/
> Cc: Ching-Te Ku <ku920601@realtek.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless.git, thanks.

cec60af1972d wifi: rtw89: coex: fix configuration for shared antenna for 8922A

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240309001348.9906-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH wireless] wifi: rtw89: coex: fix configuration for shared antenna for 8922A

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> writes:

> WiFi 2x2 + BT combo cards can be two or three physical antenna. For two
> antenna case, one antenna is shared by WiFi and BT, and different
> configuration should be applied. Fix the typo.
>
> This problem was found by Coccicheck, and actually that is a typo instead:
>   drivers/net/wireless/realtek/rtw89/rtw8922a.c:2235:2-4:
>     WARNING: possible condition with no effect (if == else)
>
> Fixes: 652c9642eda6 ("wifi: rtw89: coex: add init_info H2C command format version 7")
> Closes: https://lore.kernel.org/linux-wireless/170992024446.15593.2682606960737891240.git-patchwork-notify@kernel.org/T/#m074885bdbd91071c7d1771f08917831d9f89d95a

BTW for Closes and Link tags it's better to use a direct lore link with
Message-Id:

    Closes: https://lore.kernel.org/linux-wireless/20240308074539.04512f66@kernel.org/

The benefits are:

* as the Message-Id is in the link, the mail can be found even if
  lore.kernel.org would go away

* it's shorter

* regzbot uses the Message-Id to close the issues

In lore you can get the URL from "permalink" link. I changed the link
during commit, so no need to resend.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches