Re: [PATCH] i2c: imx: move to generic GPIO recovery

From: Esben Haabendal <esben@geanix.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: linux-i2c@vger.kernel.org,
	 Gregor Herburger <gregor.herburger@ew.tq-group.com>,
	 Pengutronix Kernel Team <kernel@pengutronix.de>,
	 Andi Shyti <andi.shyti@kernel.org>,
	 Shawn Guo <shawnguo@kernel.org>,
	 Sascha Hauer <s.hauer@pengutronix.de>,
	 Fabio Estevam <festevam@gmail.com>,
	 NXP Linux Team <linux-imx@nxp.com>,
	linux-kernel@vger.kernel.org,
	 Jinjie Ruan <ruanjinjie@huawei.com>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: imx: move to generic GPIO recovery
Date: Fri, 26 Jan 2024 08:38:08 +0100	[thread overview]
Message-ID: <875xzgh7dr.fsf@geanix.com> (raw)
In-Reply-To: <20240126060719.GD381737@pengutronix.de> (Oleksij Rempel's message of "Fri, 26 Jan 2024 07:07:19 +0100")

Oleksij Rempel <o.rempel@pengutronix.de> writes:

> ....
>> +	struct i2c_bus_recovery_info *bri = &i2c_imx->rinfo;
>>  
>> -	dev_dbg(&pdev->dev, "using scl%s for recovery\n",
>> -		rinfo->sda_gpiod ? ",sda" : "");
>> +	bri->pinctrl = devm_pinctrl_get(&pdev->dev);
>> +	if (IS_ERR(bri->pinctrl))
>> +		return PTR_ERR(bri->pinctrl);
>
> According to the commit message - "pinctrl becomes optional", but this
> code stops probe if pinctrl will fail for one or another reason. I do
> not see any place returning NULL on fail. Do I'm missing something?

The caller, i2c_imx_probe(), does only check for -EPROBE_DEFER, and
simply ignores any other error codes.

I assume it is on purpose, so any problems with initializing i2c
recovery does not cause complete failure of the i2c controller, which
seems sane to me.

/Esben