* [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
@ 2023-12-20 14:15 Konrad Dybcio
2023-12-20 14:16 ` Konrad Dybcio
2024-02-14 17:57 ` Bjorn Andersson
0 siblings, 2 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-12-20 14:15 UTC (permalink / raw)
To: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Dylan Van Assche
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Caleb Connolly, Konrad Dybcio
The SLPI is powered by the Low Power Island power rails. Fix the incorrect
assignment.
Fixes: 74588aada59a ("arm64: dts: qcom: sdm845: add SLPI remoteproc")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index c2244824355a..237d40486142 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -3366,8 +3366,8 @@ slpi_pas: remoteproc@5c00000 {
qcom,qmp = <&aoss_qmp>;
- power-domains = <&rpmhpd SDM845_CX>,
- <&rpmhpd SDM845_MX>;
+ power-domains = <&rpmhpd SDM845_LCX>,
+ <&rpmhpd SDM845_LMX>;
power-domain-names = "lcx", "lmx";
memory-region = <&slpi_mem>;
---
base-commit: 20d857259d7d10cd0d5e8b60608455986167cfad
change-id: 20231220-topic-sdm845_slpi_lcxmx-03c4f98a423d
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
2023-12-20 14:15 [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI Konrad Dybcio
@ 2023-12-20 14:16 ` Konrad Dybcio
2023-12-22 18:43 ` Konstantin Ryabitsev
2024-02-14 17:57 ` Bjorn Andersson
1 sibling, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2023-12-20 14:16 UTC (permalink / raw)
To: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Dylan Van Assche
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Caleb Connolly
On 20.12.2023 15:15, Konrad Dybcio wrote:
> The SLPI is powered by the Low Power Island power rails. Fix the incorrect
> assignment.
>
> Fixes: 74588aada59a ("arm64: dts: qcom: sdm845: add SLPI remoteproc")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
b4 seems to not have included my "only compile-tested" comment
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
2023-12-20 14:16 ` Konrad Dybcio
@ 2023-12-22 18:43 ` Konstantin Ryabitsev
2023-12-27 0:53 ` Konrad Dybcio
0 siblings, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2023-12-22 18:43 UTC (permalink / raw)
To: Konrad Dybcio; +Cc: tools
On Wed, Dec 20, 2023 at 03:16:00PM +0100, Konrad Dybcio wrote:
> On 20.12.2023 15:15, Konrad Dybcio wrote:
> > The SLPI is powered by the Low Power Island power rails. Fix the incorrect
> > assignment.
> >
> > Fixes: 74588aada59a ("arm64: dts: qcom: sdm845: add SLPI remoteproc")
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> > ---
> b4 seems to not have included my "only compile-tested" comment
Can you let me know your expected behaviour vs. what you ended up seeing?
-K
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
2023-12-22 18:43 ` Konstantin Ryabitsev
@ 2023-12-27 0:53 ` Konrad Dybcio
2024-01-02 8:07 ` Mattijs Korpershoek
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2023-12-27 0:53 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: tools
On 22.12.2023 19:43, Konstantin Ryabitsev wrote:
> On Wed, Dec 20, 2023 at 03:16:00PM +0100, Konrad Dybcio wrote:
>> On 20.12.2023 15:15, Konrad Dybcio wrote:
>>> The SLPI is powered by the Low Power Island power rails. Fix the incorrect
>>> assignment.
>>>
>>> Fixes: 74588aada59a ("arm64: dts: qcom: sdm845: add SLPI remoteproc")
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>> b4 seems to not have included my "only compile-tested" comment
>
> Can you let me know your expected behaviour vs. what you ended up seeing?
Sure!
expected: the "Only compile-tested" bit goes under the striped
line
actual: The line is ignored. And I think this happens quite
consistently with a single patch with a single line of 'cover
letter' only, maybe it interprets the series topic, but a
separate 0/1 message is of course not created.
Here's the setup:
--------------------------------------------
commit f516d7b26e4aa2e6ac87f7e989de008a99e5b26b (topic/sdm845_slpi_lcxmx)
Author: Konrad Dybcio <konrad.dybcio@linaro.org>
Date: Wed Dec 20 15:12:56 2023 +0100
arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
The SLPI is powered by the Low Power Island power rails. Fix the incorrect
assignment.
Fixes: 74588aada59a ("arm64: dts: qcom: sdm845: add SLPI remoteproc")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
commit d8d0c7257dd4cba8ca0f9f8cdfc7ab12adfd3909
Author: Konrad Dybcio <konrad.dybcio@linaro.org>
Date: Wed Dec 20 15:14:34 2023 +0100
Only compile-tested
To: Bjorn Andersson <andersson@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Dylan Van Assche <me@dylanvanassche.be>
Cc: Marijn Suijten <marijn.suijten@somainline.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Caleb Connolly <caleb.connolly@linaro.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/20231220-topic-sdm845_slpi_lcxmx-v1-1-db7c72ef99ae@linaro.org
--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes.
{
"series": {
"revision": 2,
"change-id": "20231220-topic-sdm845_slpi_lcxmx-03c4f98a423d",
"base-branch": null,
"prefixes": [],
"history": {
"v1": [
"20231220-topic-sdm845_slpi_lcxmx-v1-1-db7c72ef99ae@linaro.org"
]
}
}
}
commit 20d857259d7d10cd0d5e8b60608455986167cfad (tag: next-20231220)
--------------------------------------------
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
2023-12-27 0:53 ` Konrad Dybcio
@ 2024-01-02 8:07 ` Mattijs Korpershoek
0 siblings, 0 replies; 6+ messages in thread
From: Mattijs Korpershoek @ 2024-01-02 8:07 UTC (permalink / raw)
To: Konrad Dybcio, Konstantin Ryabitsev; +Cc: tools
Hi Konrad,
On Wed, Dec 27, 2023 at 01:53, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> On 22.12.2023 19:43, Konstantin Ryabitsev wrote:
>> On Wed, Dec 20, 2023 at 03:16:00PM +0100, Konrad Dybcio wrote:
>>> On 20.12.2023 15:15, Konrad Dybcio wrote:
>>>> The SLPI is powered by the Low Power Island power rails. Fix the incorrect
>>>> assignment.
>>>>
>>>> Fixes: 74588aada59a ("arm64: dts: qcom: sdm845: add SLPI remoteproc")
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>> ---
>>> b4 seems to not have included my "only compile-tested" comment
>>
>> Can you let me know your expected behaviour vs. what you ended up seeing?
> Sure!
>
> expected: the "Only compile-tested" bit goes under the striped
> line
>
> actual: The line is ignored. And I think this happens quite
Per my understanding, this is a "feature", not a bug.
What happens on single patches that don't want to have an additional
comment below the --- marker?
> consistently with a single patch with a single line of 'cover
> letter' only, maybe it interprets the series topic, but a
> separate 0/1 message is of course not created.
Can't this be fixed with adding a body in the commit message for 0/1 ?
See below
>
>
>
> Here's the setup:
>
>
> --------------------------------------------
> commit f516d7b26e4aa2e6ac87f7e989de008a99e5b26b (topic/sdm845_slpi_lcxmx)
> Author: Konrad Dybcio <konrad.dybcio@linaro.org>
> Date: Wed Dec 20 15:12:56 2023 +0100
>
> arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
>
> The SLPI is powered by the Low Power Island power rails. Fix the incorrect
> assignment.
>
> Fixes: 74588aada59a ("arm64: dts: qcom: sdm845: add SLPI remoteproc")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> commit d8d0c7257dd4cba8ca0f9f8cdfc7ab12adfd3909
> Author: Konrad Dybcio <konrad.dybcio@linaro.org>
> Date: Wed Dec 20 15:14:34 2023 +0100
>
> Only compile-tested # gets ignored
Add another line here: Only compile-tested.
>
> To: Bjorn Andersson <andersson@kernel.org>
> To: Rob Herring <robh+dt@kernel.org>
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> To: Conor Dooley <conor+dt@kernel.org>
> To: Dylan Van Assche <me@dylanvanassche.be>
> Cc: Marijn Suijten <marijn.suijten@somainline.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Caleb Connolly <caleb.connolly@linaro.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1: https://lore.kernel.org/r/20231220-topic-sdm845_slpi_lcxmx-v1-1-db7c72ef99ae@linaro.org
>
>
>
> --- b4-submit-tracking ---
> # This section is used internally by b4 prep for tracking purposes.
> {
> "series": {
> "revision": 2,
> "change-id": "20231220-topic-sdm845_slpi_lcxmx-03c4f98a423d",
> "base-branch": null,
> "prefixes": [],
> "history": {
> "v1": [
> "20231220-topic-sdm845_slpi_lcxmx-v1-1-db7c72ef99ae@linaro.org"
> ]
> }
> }
> }
>
> commit 20d857259d7d10cd0d5e8b60608455986167cfad (tag: next-20231220)
>
> --------------------------------------------
>
> Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
2023-12-20 14:15 [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI Konrad Dybcio
2023-12-20 14:16 ` Konrad Dybcio
@ 2024-02-14 17:57 ` Bjorn Andersson
1 sibling, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2024-02-14 17:57 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dylan Van Assche,
Konrad Dybcio
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Caleb Connolly
On Wed, 20 Dec 2023 15:15:11 +0100, Konrad Dybcio wrote:
> The SLPI is powered by the Low Power Island power rails. Fix the incorrect
> assignment.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI
commit: 5dd227ccfb9568935bdaf82bc1893b36457dd4d3
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-14 17:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-20 14:15 [PATCH] arm64: dts: qcom: sdm845: Use the Low Power Island CX/MX for SLPI Konrad Dybcio
2023-12-20 14:16 ` Konrad Dybcio
2023-12-22 18:43 ` Konstantin Ryabitsev
2023-12-27 0:53 ` Konrad Dybcio
2024-01-02 8:07 ` Mattijs Korpershoek
2024-02-14 17:57 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.