From: Jani Nikula <jani.nikula@intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
Matthew Auld <matthew.auld@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Add helper func to get intel_fbdev from drm_fb_helper
Date: Mon, 20 Mar 2023 12:39:41 +0200 [thread overview]
Message-ID: <875yavaeqa.fsf@intel.com> (raw)
In-Reply-To: <20230320100903.23588-2-nirmoy.das@intel.com>
On Mon, 20 Mar 2023, Nirmoy Das <nirmoy.das@intel.com> wrote:
> Add a helper function to retrieve struct intel_fbdev from
> struct drm_fb_helper.
>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbdev.c | 23 ++++++++++------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 673bcdfb7ff6..8c3b3c3fd0e0 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -67,6 +67,11 @@ struct intel_fbdev {
> struct mutex hpd_lock;
> };
>
> +static struct intel_fbdev *to_intel_fbdev(struct drm_fb_helper *fb_helper)
> +{
> + return container_of(fb_helper, struct intel_fbdev, helper);
> +}
> +
> static struct intel_frontbuffer *to_frontbuffer(struct intel_fbdev *ifbdev)
> {
> return ifbdev->fb->frontbuffer;
> @@ -79,9 +84,7 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev)
>
> static int intel_fbdev_set_par(struct fb_info *info)
> {
> - struct drm_fb_helper *fb_helper = info->par;
> - struct intel_fbdev *ifbdev =
> - container_of(fb_helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par);
> int ret;
>
> ret = drm_fb_helper_set_par(info);
> @@ -93,9 +96,7 @@ static int intel_fbdev_set_par(struct fb_info *info)
>
> static int intel_fbdev_blank(int blank, struct fb_info *info)
> {
> - struct drm_fb_helper *fb_helper = info->par;
> - struct intel_fbdev *ifbdev =
> - container_of(fb_helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par);
> int ret;
>
> ret = drm_fb_helper_blank(blank, info);
> @@ -108,9 +109,7 @@ static int intel_fbdev_blank(int blank, struct fb_info *info)
> static int intel_fbdev_pan_display(struct fb_var_screeninfo *var,
> struct fb_info *info)
> {
> - struct drm_fb_helper *fb_helper = info->par;
> - struct intel_fbdev *ifbdev =
> - container_of(fb_helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par);
> int ret;
>
> ret = drm_fb_helper_pan_display(var, info);
> @@ -136,8 +135,7 @@ static const struct fb_ops intelfb_ops = {
> static int intelfb_alloc(struct drm_fb_helper *helper,
> struct drm_fb_helper_surface_size *sizes)
> {
> - struct intel_fbdev *ifbdev =
> - container_of(helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(helper);
> struct drm_framebuffer *fb;
> struct drm_device *dev = helper->dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
> @@ -193,8 +191,7 @@ static int intelfb_alloc(struct drm_fb_helper *helper,
> static int intelfb_create(struct drm_fb_helper *helper,
> struct drm_fb_helper_surface_size *sizes)
> {
> - struct intel_fbdev *ifbdev =
> - container_of(helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(helper);
> struct intel_framebuffer *intel_fb = ifbdev->fb;
> struct drm_device *dev = helper->dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
Matthew Auld <matthew.auld@intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [PATCH 2/3] drm/i915/display: Add helper func to get intel_fbdev from drm_fb_helper
Date: Mon, 20 Mar 2023 12:39:41 +0200 [thread overview]
Message-ID: <875yavaeqa.fsf@intel.com> (raw)
In-Reply-To: <20230320100903.23588-2-nirmoy.das@intel.com>
On Mon, 20 Mar 2023, Nirmoy Das <nirmoy.das@intel.com> wrote:
> Add a helper function to retrieve struct intel_fbdev from
> struct drm_fb_helper.
>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbdev.c | 23 ++++++++++------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 673bcdfb7ff6..8c3b3c3fd0e0 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -67,6 +67,11 @@ struct intel_fbdev {
> struct mutex hpd_lock;
> };
>
> +static struct intel_fbdev *to_intel_fbdev(struct drm_fb_helper *fb_helper)
> +{
> + return container_of(fb_helper, struct intel_fbdev, helper);
> +}
> +
> static struct intel_frontbuffer *to_frontbuffer(struct intel_fbdev *ifbdev)
> {
> return ifbdev->fb->frontbuffer;
> @@ -79,9 +84,7 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev)
>
> static int intel_fbdev_set_par(struct fb_info *info)
> {
> - struct drm_fb_helper *fb_helper = info->par;
> - struct intel_fbdev *ifbdev =
> - container_of(fb_helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par);
> int ret;
>
> ret = drm_fb_helper_set_par(info);
> @@ -93,9 +96,7 @@ static int intel_fbdev_set_par(struct fb_info *info)
>
> static int intel_fbdev_blank(int blank, struct fb_info *info)
> {
> - struct drm_fb_helper *fb_helper = info->par;
> - struct intel_fbdev *ifbdev =
> - container_of(fb_helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par);
> int ret;
>
> ret = drm_fb_helper_blank(blank, info);
> @@ -108,9 +109,7 @@ static int intel_fbdev_blank(int blank, struct fb_info *info)
> static int intel_fbdev_pan_display(struct fb_var_screeninfo *var,
> struct fb_info *info)
> {
> - struct drm_fb_helper *fb_helper = info->par;
> - struct intel_fbdev *ifbdev =
> - container_of(fb_helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par);
> int ret;
>
> ret = drm_fb_helper_pan_display(var, info);
> @@ -136,8 +135,7 @@ static const struct fb_ops intelfb_ops = {
> static int intelfb_alloc(struct drm_fb_helper *helper,
> struct drm_fb_helper_surface_size *sizes)
> {
> - struct intel_fbdev *ifbdev =
> - container_of(helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(helper);
> struct drm_framebuffer *fb;
> struct drm_device *dev = helper->dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
> @@ -193,8 +191,7 @@ static int intelfb_alloc(struct drm_fb_helper *helper,
> static int intelfb_create(struct drm_fb_helper *helper,
> struct drm_fb_helper_surface_size *sizes)
> {
> - struct intel_fbdev *ifbdev =
> - container_of(helper, struct intel_fbdev, helper);
> + struct intel_fbdev *ifbdev = to_intel_fbdev(helper);
> struct intel_framebuffer *intel_fb = ifbdev->fb;
> struct drm_device *dev = helper->dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-03-20 10:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 10:09 [Intel-gfx] [PATCH v2: 1/3] drm/i915: Add a function to mmap framebuffer obj Nirmoy Das
2023-03-20 10:09 ` Nirmoy Das
2023-03-20 10:09 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: Add helper func to get intel_fbdev from drm_fb_helper Nirmoy Das
2023-03-20 10:09 ` Nirmoy Das
2023-03-20 10:39 ` Jani Nikula [this message]
2023-03-20 10:39 ` Jani Nikula
2023-03-20 10:49 ` [Intel-gfx] " Andi Shyti
2023-03-20 10:49 ` Andi Shyti
2023-03-20 13:58 ` [Intel-gfx] " Andrzej Hajda
2023-03-20 10:09 ` [Intel-gfx] [PATCH RFC 3/3] drm/i915/display: Implement fb_mmap callback function Nirmoy Das
2023-03-20 10:09 ` Nirmoy Das
2023-03-20 14:00 ` [Intel-gfx] " Andrzej Hajda
2023-03-20 14:02 ` [Intel-gfx] [PATCH v2: 1/3] drm/i915: Add a function to mmap framebuffer obj Andrzej Hajda
2023-03-23 8:00 ` Das, Nirmoy
2023-03-20 19:36 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning for series starting with [v2:,1/3] " Patchwork
2023-03-20 19:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: " Patchwork
2023-03-20 19:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-20 20:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-20 23:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-03-23 10:01 [Intel-gfx] [PATCH v2 1/3] " Nirmoy Das
2023-03-23 10:01 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: Add helper func to get intel_fbdev from drm_fb_helper Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yavaeqa.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.