From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
"open list:Block layer core" <qemu-block@nongnu.org>,
"open list:virtiofs" <virtio-fs@redhat.com>
Subject: Re: [Virtio-fs] [RFC PATCH] hw/virtio: introduce virtio_device_should_start
Date: Mon, 07 Nov 2022 13:30:38 +0000 [thread overview]
Message-ID: <875yfqhl2o.fsf@linaro.org> (raw)
In-Reply-To: <20221107071516-mutt-send-email-mst@kernel.org>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Mon, Nov 07, 2022 at 12:14:07PM +0000, Alex Bennée wrote:
>> The previous fix to virtio_device_started revealed a problem in its
>> use by both the core and the device code. The core code should be able
>> to handle the device "starting" while the VM isn't running to handle
>> the restoration of migration state. To solve this duel use introduce a
>> new helper for use by the vhost-user backends who all use it to feed a
>> should_start variable.
>>
>> We can also pick up a change vhost_user_blk_set_status while we are at
>> it which follows the same pattern.
>>
>> Fixes: 9f6bcfd99f (hw/virtio: move vm_running check to virtio_device_started)
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>
> Hi Alex, did you actually check this under gitlab CI?
It's had a clean pass as part of my for-7.2/misc-fixes branch but I've
been unable to replicate the crash it was meant to fix locally as of
yet.
https://gitlab.com/stsquad/qemu/-/pipelines/687366712
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
"open list:Block layer core" <qemu-block@nongnu.org>,
"open list:virtiofs" <virtio-fs@redhat.com>
Subject: Re: [RFC PATCH] hw/virtio: introduce virtio_device_should_start
Date: Mon, 07 Nov 2022 13:30:38 +0000 [thread overview]
Message-ID: <875yfqhl2o.fsf@linaro.org> (raw)
In-Reply-To: <20221107071516-mutt-send-email-mst@kernel.org>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Mon, Nov 07, 2022 at 12:14:07PM +0000, Alex Bennée wrote:
>> The previous fix to virtio_device_started revealed a problem in its
>> use by both the core and the device code. The core code should be able
>> to handle the device "starting" while the VM isn't running to handle
>> the restoration of migration state. To solve this duel use introduce a
>> new helper for use by the vhost-user backends who all use it to feed a
>> should_start variable.
>>
>> We can also pick up a change vhost_user_blk_set_status while we are at
>> it which follows the same pattern.
>>
>> Fixes: 9f6bcfd99f (hw/virtio: move vm_running check to virtio_device_started)
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>
> Hi Alex, did you actually check this under gitlab CI?
It's had a clean pass as part of my for-7.2/misc-fixes branch but I've
been unable to replicate the crash it was meant to fix locally as of
yet.
https://gitlab.com/stsquad/qemu/-/pipelines/687366712
--
Alex Bennée
next prev parent reply other threads:[~2022-11-07 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 12:14 [Virtio-fs] [RFC PATCH] hw/virtio: introduce virtio_device_should_start Alex Bennée
2022-11-07 12:14 ` Alex Bennée
2022-11-07 12:16 ` [Virtio-fs] " Michael S. Tsirkin
2022-11-07 12:16 ` Michael S. Tsirkin
2022-11-07 13:30 ` Alex Bennée [this message]
2022-11-07 13:30 ` Alex Bennée
2022-11-07 14:31 ` [Virtio-fs] " Michael S. Tsirkin
2022-11-07 14:31 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yfqhl2o.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=dgilbert@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.