From: Kalle Valo <kvalo@kernel.org>
To: Abhishek Kumar <kuabhs@chromium.org>
Cc: netdev@vger.kernel.org, dianders@chromium.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v3] ath10k: improve BDF search fallback strategy
Date: Tue, 10 May 2022 18:46:39 +0300 [thread overview]
Message-ID: <875ymd8k68.fsf@kernel.org> (raw)
In-Reply-To: <87a6bp8kfn.fsf@kernel.org> (Kalle Valo's message of "Tue, 10 May 2022 18:41:00 +0300")
Kalle Valo <kvalo@kernel.org> writes:
>> static int ath10k_core_fetch_board_data_api_n(struct ath10k *ar,
>> const char *boardname,
>> - const char *fallback_boardname1,
>> - const char *fallback_boardname2,
>> const char *filename)
>> {
>> - size_t len, magic_len;
>> + size_t len, magic_len, board_len;
>> const u8 *data;
>> int ret;
>> + char temp_boardname[100];
>> +
>> + board_len = 100 * sizeof(temp_boardname[0]);
>
> Why not:
>
> board_len = sizeof(temp_board-name);
>
> That way number 100 is used only once.
BTW I'm not sure if it makes sense to CC David, Eric, Jakub and Paolo.
I'm sure they get a lot of email already. And I would also drop netdev.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Abhishek Kumar <kuabhs@chromium.org>
Cc: netdev@vger.kernel.org, dianders@chromium.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v3] ath10k: improve BDF search fallback strategy
Date: Tue, 10 May 2022 18:46:39 +0300 [thread overview]
Message-ID: <875ymd8k68.fsf@kernel.org> (raw)
In-Reply-To: <87a6bp8kfn.fsf@kernel.org> (Kalle Valo's message of "Tue, 10 May 2022 18:41:00 +0300")
Kalle Valo <kvalo@kernel.org> writes:
>> static int ath10k_core_fetch_board_data_api_n(struct ath10k *ar,
>> const char *boardname,
>> - const char *fallback_boardname1,
>> - const char *fallback_boardname2,
>> const char *filename)
>> {
>> - size_t len, magic_len;
>> + size_t len, magic_len, board_len;
>> const u8 *data;
>> int ret;
>> + char temp_boardname[100];
>> +
>> + board_len = 100 * sizeof(temp_boardname[0]);
>
> Why not:
>
> board_len = sizeof(temp_board-name);
>
> That way number 100 is used only once.
BTW I'm not sure if it makes sense to CC David, Eric, Jakub and Paolo.
I'm sure they get a lot of email already. And I would also drop netdev.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-05-10 15:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 2:26 [PATCH v3] ath10k: improve BDF search fallback strategy Abhishek Kumar
2022-05-09 2:26 ` Abhishek Kumar
2022-05-09 17:22 ` Jeff Johnson
2022-05-09 17:22 ` Jeff Johnson
[not found] ` <CAB5ih=O325ndrYqLWwug01tSmketLDrsJgtX5DvR38Om6T8ZCQ@mail.gmail.com>
2022-05-10 2:17 ` Abhishek Kumar
2022-05-10 2:17 ` Abhishek Kumar
2022-05-10 15:41 ` Kalle Valo
2022-05-10 15:41 ` Kalle Valo
2022-05-10 15:46 ` Kalle Valo [this message]
2022-05-10 15:46 ` Kalle Valo
2022-05-11 13:34 ` Kalle Valo
2022-05-11 13:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ymd8k68.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=edumazet@google.com \
--cc=kuabhs@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.