All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] irqchip/aspeed-i2c-ic: Fix irq_of_parse_and_map() return value
@ 2022-04-22 10:45 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-22 10:45 UTC (permalink / raw)
  To: linux-aspeed

The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.

Fixes: f48e699ddf70 ("irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/irqchip/irq-aspeed-i2c-ic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-aspeed-i2c-ic.c b/drivers/irqchip/irq-aspeed-i2c-ic.c
index a47db16ff960..cef1291ae783 100644
--- a/drivers/irqchip/irq-aspeed-i2c-ic.c
+++ b/drivers/irqchip/irq-aspeed-i2c-ic.c
@@ -77,7 +77,7 @@ static int __init aspeed_i2c_ic_of_init(struct device_node *node,
 	}
 
 	i2c_ic->parent_irq = irq_of_parse_and_map(node, 0);
-	if (i2c_ic->parent_irq < 0) {
+	if (!i2c_ic->parent_irq) {
 		ret = i2c_ic->parent_irq;
 		goto err_iounmap;
 	}
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-04-23  9:44 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-22 10:45 [PATCH 1/2] irqchip/aspeed-i2c-ic: Fix irq_of_parse_and_map() return value Krzysztof Kozlowski
2022-04-22 10:45 ` Krzysztof Kozlowski
2022-04-22 10:45 ` Krzysztof Kozlowski
2022-04-22 10:45 ` [PATCH 2/2] irqchip/aspeed-scu-ic: " Krzysztof Kozlowski
2022-04-22 10:45   ` Krzysztof Kozlowski
2022-04-22 10:45   ` Krzysztof Kozlowski
2022-04-23  9:30 ` [PATCH 1/2] irqchip/aspeed-i2c-ic: " Krzysztof Kozlowski
2022-04-23  9:30   ` Krzysztof Kozlowski
2022-04-23  9:30   ` Krzysztof Kozlowski
2022-04-23  9:43   ` Marc Zyngier
2022-04-23  9:43     ` Marc Zyngier
2022-04-23  9:43     ` Marc Zyngier
2022-04-23  9:43     ` Marc Zyngier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.