From: Joachim Wiberg <troglobit@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S . Miller" <davem@davemloft.net>,
Roopa Prabhu <roopa@nvidia.com>
Subject: Re: [Bridge] [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb entries
Date: Thu, 24 Feb 2022 17:29:35 +0100 [thread overview]
Message-ID: <875yp4qlcg.fsf@gmail.com> (raw)
In-Reply-To: <20220224080611.4e32bac3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Feb 24, 2022 at 08:06, Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 24 Feb 2022 13:26:22 +0200 Nikolay Aleksandrov wrote:
>> On 23/02/2022 19:24, Joachim Wiberg wrote:
>> > This patch expands on the earlier work on layer-2 mdb entries by adding
>> > support for host entries.
>> It would be nice to add a selftest for L2 entries. You can send it as a follow-up.
> Let's wait for that, also checkpatch says you need to balance brackets
> to hold kernel coding style.
Jakub, by "wait for that" do you mean you'd prefer I add the selftests
to this? Otherwise I'll send a v2 with the style fixes.
Best regards
/Joachim
WARNING: multiple messages have this Message-ID (diff)
From: Joachim Wiberg <troglobit@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: Roopa Prabhu <roopa@nvidia.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb entries
Date: Thu, 24 Feb 2022 17:29:35 +0100 [thread overview]
Message-ID: <875yp4qlcg.fsf@gmail.com> (raw)
In-Reply-To: <20220224080611.4e32bac3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Feb 24, 2022 at 08:06, Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 24 Feb 2022 13:26:22 +0200 Nikolay Aleksandrov wrote:
>> On 23/02/2022 19:24, Joachim Wiberg wrote:
>> > This patch expands on the earlier work on layer-2 mdb entries by adding
>> > support for host entries.
>> It would be nice to add a selftest for L2 entries. You can send it as a follow-up.
> Let's wait for that, also checkpatch says you need to balance brackets
> to hold kernel coding style.
Jakub, by "wait for that" do you mean you'd prefer I add the selftests
to this? Otherwise I'll send a v2 with the style fixes.
Best regards
/Joachim
next prev parent reply other threads:[~2022-02-24 16:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 17:24 [Bridge] [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb entries Joachim Wiberg
2022-02-23 17:24 ` Joachim Wiberg
2022-02-24 11:26 ` [Bridge] " Nikolay Aleksandrov
2022-02-24 11:26 ` Nikolay Aleksandrov
2022-02-24 13:59 ` [Bridge] " Joachim Wiberg
2022-02-24 13:59 ` Joachim Wiberg
2022-02-24 16:06 ` [Bridge] " Jakub Kicinski
2022-02-24 16:06 ` Jakub Kicinski
2022-02-24 16:29 ` Joachim Wiberg [this message]
2022-02-24 16:29 ` Joachim Wiberg
2022-02-24 16:48 ` [Bridge] " Jakub Kicinski
2022-02-24 16:48 ` Jakub Kicinski
2022-02-24 17:27 ` [Bridge] " Joachim Wiberg
2022-02-24 17:27 ` Joachim Wiberg
2022-04-11 8:40 ` [Bridge] [PATCH v2 net-next 0/2] " Joachim Wiberg
2022-04-11 8:40 ` Joachim Wiberg
2022-04-11 8:40 ` [Bridge] [PATCH v2 net-next 1/2] " Joachim Wiberg
2022-04-11 8:40 ` Joachim Wiberg
2022-04-11 8:40 ` [Bridge] [PATCH v2 net-next 2/2] selftests: forwarding: new test, verify host " Joachim Wiberg
2022-04-11 8:40 ` Joachim Wiberg
2022-04-12 8:30 ` [Bridge] [PATCH v2 net-next 0/2] net: bridge: add support for host l2 " patchwork-bot+netdevbpf
2022-04-12 8:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yp4qlcg.fsf@gmail.com \
--to=troglobit@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.