* [PATCH] time/timekeeping: Fix syntax errors in comments
@ 2021-12-12 14:32 Xiang wangx
2021-12-17 22:26 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Xiang wangx @ 2021-12-12 14:32 UTC (permalink / raw)
To: john.stultz; +Cc: tglx, sboyd, linux-kernel, Xiang wangx
Delete the redundant word 'time'.
Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
---
kernel/time/timekeeping.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index b348749a9fc6..b1fbedd35300 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -1148,7 +1148,7 @@ static int adjust_historical_crosststamp(struct system_time_snapshot *history,
return ret;
}
- /* Fixup monotonic raw and real time time values */
+ /* Fixup monotonic raw and real time values */
if (interp_forward) {
ts->sys_monoraw = ktime_add_ns(history->raw, corr_raw);
ts->sys_realtime = ktime_add_ns(history->real, corr_real);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] time/timekeeping: Fix syntax errors in comments
2021-12-12 14:32 [PATCH] time/timekeeping: Fix syntax errors in comments Xiang wangx
@ 2021-12-17 22:26 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2021-12-17 22:26 UTC (permalink / raw)
To: Xiang wangx, john.stultz; +Cc: sboyd, linux-kernel
On Sun, Dec 12 2021 at 22:32, Xiang wangx wrote:
> Delete the redundant word 'time'.
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
> ---
> kernel/time/timekeeping.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index b348749a9fc6..b1fbedd35300 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -1148,7 +1148,7 @@ static int adjust_historical_crosststamp(struct system_time_snapshot *history,
> return ret;
> }
>
> - /* Fixup monotonic raw and real time time values */
> + /* Fixup monotonic raw and real time values */
It's not redundant because it talks about 'time values'. The 'time
values' which are fixed up are 'monotonic raw' and 'real time'.
So yes, the comment _is_ awkward and hard to read, but removing time
does not make it any better. Something like this;
/* Fixup the MONOTONIC_RAW and REAL_TIME time values */
Hmm?
Thanks,
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-17 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-12 14:32 [PATCH] time/timekeeping: Fix syntax errors in comments Xiang wangx
2021-12-17 22:26 ` Thomas Gleixner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.