From: Marc Zyngier <maz@kernel.org>
To: Jia He <justin.he@arm.com>
Cc: Xiaoming Ni <nixiaoming@huawei.com>,
Shenming Lu <lushenming@huawei.com>,
Kees Cook <keescook@chromium.org>, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, Liu Shixin <liushixin2@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sami Tolvanen <samitolvanen@google.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] KVM: arm64: Add memcg accounting to KVM allocations
Date: Thu, 02 Sep 2021 19:11:48 +0100 [thread overview]
Message-ID: <875yvix2xn.wl-maz@kernel.org> (raw)
In-Reply-To: <20210902002801.32618-2-justin.he@arm.com>
On Thu, 02 Sep 2021 01:28:01 +0100,
Jia He <justin.he@arm.com> wrote:
>
> Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM
> allocations"), it would be better to make arm64 KVM consistent with
> common kvm codes.
>
> The memory allocations of VM scope should be charged into VM process
> cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT.
>
> There remained a few cases since these allocations are global, not in VM
> scope.
>
> Signed-off-by: Jia He <justin.he@arm.com>
> ---
> arch/arm64/kvm/arm.c | 6 ++++--
> arch/arm64/kvm/mmu.c | 2 +-
> arch/arm64/kvm/pmu-emul.c | 2 +-
> arch/arm64/kvm/reset.c | 2 +-
> 4 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index e9a2b8f27792..9d6f5bcaddef 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -289,10 +289,12 @@ long kvm_arch_dev_ioctl(struct file *filp,
>
> struct kvm *kvm_arch_alloc_vm(void)
> {
> + unsigned long sz = sizeof(struct kvm);
If you are going to introduce an extra variable, please use the
correct type (size_t).
> +
> if (!has_vhe())
> - return kzalloc(sizeof(struct kvm), GFP_KERNEL);
> + return kzalloc(sz, GFP_KERNEL | GFP_KERNEL_ACCOUNT);
Why both GFP_KERNEL and GFP_KERNEL_ACCOUNT?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Jia He <justin.he@arm.com>
Cc: James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Liu Shixin <liushixin2@huawei.com>,
Eric Auger <eric.auger@redhat.com>,
Kees Cook <keescook@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Shenming Lu <lushenming@huawei.com>,
Sami Tolvanen <samitolvanen@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Xiaoming Ni <nixiaoming@huawei.com>,
Zenghui Yu <yuzenghui@huawei.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: arm64: Add memcg accounting to KVM allocations
Date: Thu, 02 Sep 2021 19:11:48 +0100 [thread overview]
Message-ID: <875yvix2xn.wl-maz@kernel.org> (raw)
In-Reply-To: <20210902002801.32618-2-justin.he@arm.com>
On Thu, 02 Sep 2021 01:28:01 +0100,
Jia He <justin.he@arm.com> wrote:
>
> Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM
> allocations"), it would be better to make arm64 KVM consistent with
> common kvm codes.
>
> The memory allocations of VM scope should be charged into VM process
> cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT.
>
> There remained a few cases since these allocations are global, not in VM
> scope.
>
> Signed-off-by: Jia He <justin.he@arm.com>
> ---
> arch/arm64/kvm/arm.c | 6 ++++--
> arch/arm64/kvm/mmu.c | 2 +-
> arch/arm64/kvm/pmu-emul.c | 2 +-
> arch/arm64/kvm/reset.c | 2 +-
> 4 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index e9a2b8f27792..9d6f5bcaddef 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -289,10 +289,12 @@ long kvm_arch_dev_ioctl(struct file *filp,
>
> struct kvm *kvm_arch_alloc_vm(void)
> {
> + unsigned long sz = sizeof(struct kvm);
If you are going to introduce an extra variable, please use the
correct type (size_t).
> +
> if (!has_vhe())
> - return kzalloc(sizeof(struct kvm), GFP_KERNEL);
> + return kzalloc(sz, GFP_KERNEL | GFP_KERNEL_ACCOUNT);
Why both GFP_KERNEL and GFP_KERNEL_ACCOUNT?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Jia He <justin.he@arm.com>
Cc: James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Liu Shixin <liushixin2@huawei.com>,
Eric Auger <eric.auger@redhat.com>,
Kees Cook <keescook@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Shenming Lu <lushenming@huawei.com>,
Sami Tolvanen <samitolvanen@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Xiaoming Ni <nixiaoming@huawei.com>,
Zenghui Yu <yuzenghui@huawei.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: arm64: Add memcg accounting to KVM allocations
Date: Thu, 02 Sep 2021 19:11:48 +0100 [thread overview]
Message-ID: <875yvix2xn.wl-maz@kernel.org> (raw)
In-Reply-To: <20210902002801.32618-2-justin.he@arm.com>
On Thu, 02 Sep 2021 01:28:01 +0100,
Jia He <justin.he@arm.com> wrote:
>
> Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM
> allocations"), it would be better to make arm64 KVM consistent with
> common kvm codes.
>
> The memory allocations of VM scope should be charged into VM process
> cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT.
>
> There remained a few cases since these allocations are global, not in VM
> scope.
>
> Signed-off-by: Jia He <justin.he@arm.com>
> ---
> arch/arm64/kvm/arm.c | 6 ++++--
> arch/arm64/kvm/mmu.c | 2 +-
> arch/arm64/kvm/pmu-emul.c | 2 +-
> arch/arm64/kvm/reset.c | 2 +-
> 4 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index e9a2b8f27792..9d6f5bcaddef 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -289,10 +289,12 @@ long kvm_arch_dev_ioctl(struct file *filp,
>
> struct kvm *kvm_arch_alloc_vm(void)
> {
> + unsigned long sz = sizeof(struct kvm);
If you are going to introduce an extra variable, please use the
correct type (size_t).
> +
> if (!has_vhe())
> - return kzalloc(sizeof(struct kvm), GFP_KERNEL);
> + return kzalloc(sz, GFP_KERNEL | GFP_KERNEL_ACCOUNT);
Why both GFP_KERNEL and GFP_KERNEL_ACCOUNT?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-09-02 18:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 0:28 [PATCH 1/2] KVM: arm64: vgic: Add memcg accounting to vgic allocations Jia He
2021-09-02 0:28 ` Jia He
2021-09-02 0:28 ` Jia He
2021-09-02 0:28 ` [PATCH 2/2] KVM: arm64: Add memcg accounting to KVM allocations Jia He
2021-09-02 0:28 ` Jia He
2021-09-02 0:28 ` Jia He
2021-09-02 18:11 ` Marc Zyngier [this message]
2021-09-02 18:11 ` Marc Zyngier
2021-09-02 18:11 ` Marc Zyngier
2021-09-03 9:21 ` Justin He
2021-09-03 9:21 ` Justin He
2021-09-03 9:21 ` Justin He
2021-09-02 18:03 ` [PATCH 1/2] KVM: arm64: vgic: Add memcg accounting to vgic allocations Marc Zyngier
2021-09-02 18:03 ` Marc Zyngier
2021-09-02 18:03 ` Marc Zyngier
2021-09-03 9:18 ` Justin He
2021-09-03 9:18 ` Justin He
2021-09-03 9:18 ` Justin He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yvix2xn.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=justin.he@arm.com \
--cc=keescook@chromium.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=lushenming@huawei.com \
--cc=ndesaulniers@google.com \
--cc=nixiaoming@huawei.com \
--cc=samitolvanen@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.