From: Nathan Lynch <nathanl@linux.ibm.com>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: cheloha@linux.ibm.com, linux-kernel@vger.kernel.org,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4] pseries: prevent free CPU ids to be reused on another node
Date: Wed, 07 Apr 2021 14:48:27 -0500 [thread overview]
Message-ID: <875z0xlvuc.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210407153808.59993-1-ldufour@linux.ibm.com>
Laurent Dufour <ldufour@linux.ibm.com> writes:
>
> Changes since V3, addressing Nathan's comment:
> - Rename the local variable named 'nid' into 'assigned_node'
> Changes since V2, addressing Nathan's comments:
> - Remove the retry feature
> - Reduce the number of local variables (removing 'i')
> - Add comment about the cpu_add_remove_lock protecting the added CPU mask.
> Changes since V1 (no functional changes):
> - update the test's output in the commit's description
> - node_recorded_ids_map should be static
>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
Thanks Laurent.
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <nathanl@linux.ibm.com>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: cheloha@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, mpe@ellerman.id.au,
benh@kernel.crashing.org, paulus@samba.org
Subject: Re: [PATCH v4] pseries: prevent free CPU ids to be reused on another node
Date: Wed, 07 Apr 2021 14:48:27 -0500 [thread overview]
Message-ID: <875z0xlvuc.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210407153808.59993-1-ldufour@linux.ibm.com>
Laurent Dufour <ldufour@linux.ibm.com> writes:
>
> Changes since V3, addressing Nathan's comment:
> - Rename the local variable named 'nid' into 'assigned_node'
> Changes since V2, addressing Nathan's comments:
> - Remove the retry feature
> - Reduce the number of local variables (removing 'i')
> - Add comment about the cpu_add_remove_lock protecting the added CPU mask.
> Changes since V1 (no functional changes):
> - update the test's output in the commit's description
> - node_recorded_ids_map should be static
>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
Thanks Laurent.
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
next prev parent reply other threads:[~2021-04-07 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 15:38 [PATCH v4] pseries: prevent free CPU ids to be reused on another node Laurent Dufour
2021-04-07 19:48 ` Nathan Lynch [this message]
2021-04-07 19:48 ` Nathan Lynch
2021-04-20 16:34 ` Laurent Dufour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z0xlvuc.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=cheloha@linux.ibm.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.