All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, Dave.Martin@arm.com, pbonzini@redhat.com,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 3/4] KVM: selftests: Update aarch64 get-reg-list blessed list
Date: Sat, 31 Oct 2020 18:53:56 +0000	[thread overview]
Message-ID: <875z6qdy63.wl-maz@kernel.org> (raw)
In-Reply-To: <20201029201703.102716-4-drjones@redhat.com>

On Thu, 29 Oct 2020 20:17:02 +0000,
Andrew Jones <drjones@redhat.com> wrote:
> 
> The new registers come from the following commits:
> 
> commit 99adb567632b ("KVM: arm/arm64: Add save/restore support for
> firmware workaround state")
> 
> commit c773ae2b3476 ("KVM: arm64: Save/Restore guest DISR_EL1")
> 
> commit 03fdfb269009 ("KVM: arm64: Don't write junk to sysregs on reset")
> 
> The last commit, which adds ARM64_SYS_REG(3, 3, 9, 12, 0) (PMCR_EL0),
> and was committed for v5.3, doesn't indicate in its commit message that
> enumerating it for save/restore was the plan, so doing so may have
> been by accident.

It definitely was.

> It's a good idea anyway, though, since the other PMU registers have
> been enumerated since v4.10.

Quite. The state of the PMU is pretty much unknown on restore until then.

> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  tools/testing/selftests/kvm/aarch64/get-reg-list.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/aarch64/get-reg-list.c b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> index 3aeb3de780a1..3ff097f6886e 100644
> --- a/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> +++ b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> @@ -352,7 +352,8 @@ int main(int ac, char **av)
>  }
>  
>  /*
> - * The current blessed list comes from kernel version v4.15 with --core-reg-fixup
> + * The current blessed list was primed with the output of kernel version
> + * v4.15 with --core-reg-fixup and then later updated with new registers.

Maybe have a reference to the last kernel version this was checked
against? Either here or in the commit message?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	pbonzini@redhat.com, Dave.Martin@arm.com,
	peter.maydell@linaro.org, eric.auger@redhat.com
Subject: Re: [PATCH 3/4] KVM: selftests: Update aarch64 get-reg-list blessed list
Date: Sat, 31 Oct 2020 18:53:56 +0000	[thread overview]
Message-ID: <875z6qdy63.wl-maz@kernel.org> (raw)
In-Reply-To: <20201029201703.102716-4-drjones@redhat.com>

On Thu, 29 Oct 2020 20:17:02 +0000,
Andrew Jones <drjones@redhat.com> wrote:
> 
> The new registers come from the following commits:
> 
> commit 99adb567632b ("KVM: arm/arm64: Add save/restore support for
> firmware workaround state")
> 
> commit c773ae2b3476 ("KVM: arm64: Save/Restore guest DISR_EL1")
> 
> commit 03fdfb269009 ("KVM: arm64: Don't write junk to sysregs on reset")
> 
> The last commit, which adds ARM64_SYS_REG(3, 3, 9, 12, 0) (PMCR_EL0),
> and was committed for v5.3, doesn't indicate in its commit message that
> enumerating it for save/restore was the plan, so doing so may have
> been by accident.

It definitely was.

> It's a good idea anyway, though, since the other PMU registers have
> been enumerated since v4.10.

Quite. The state of the PMU is pretty much unknown on restore until then.

> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  tools/testing/selftests/kvm/aarch64/get-reg-list.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/aarch64/get-reg-list.c b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> index 3aeb3de780a1..3ff097f6886e 100644
> --- a/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> +++ b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
> @@ -352,7 +352,8 @@ int main(int ac, char **av)
>  }
>  
>  /*
> - * The current blessed list comes from kernel version v4.15 with --core-reg-fixup
> + * The current blessed list was primed with the output of kernel version
> + * v4.15 with --core-reg-fixup and then later updated with new registers.

Maybe have a reference to the last kernel version this was checked
against? Either here or in the commit message?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2020-10-31 18:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 20:16 [PATCH 0/4] KVM: selftests: Add get-reg-list regression test Andrew Jones
2020-10-29 20:16 ` Andrew Jones
2020-10-29 20:17 ` [PATCH 1/4] KVM: selftests: Don't require THP to run tests Andrew Jones
2020-10-29 20:17   ` Andrew Jones
2020-10-29 20:17 ` [PATCH 2/4] KVM: selftests: Add aarch64 get-reg-list test Andrew Jones
2020-10-29 20:17   ` Andrew Jones
2020-10-29 20:17 ` [PATCH 3/4] KVM: selftests: Update aarch64 get-reg-list blessed list Andrew Jones
2020-10-29 20:17   ` Andrew Jones
2020-10-31 18:53   ` Marc Zyngier [this message]
2020-10-31 18:53     ` Marc Zyngier
2020-11-02  8:38     ` Andrew Jones
2020-11-02  8:38       ` Andrew Jones
2020-10-29 20:17 ` [PATCH 4/4] KVM: selftests: Add blessed SVE registers to get-reg-list Andrew Jones
2020-10-29 20:17   ` Andrew Jones
2020-10-29 20:24 ` [PATCH 0/4] KVM: selftests: Add get-reg-list regression test Auger Eric
2020-10-29 20:24   ` Auger Eric
2020-11-09  9:14 ` Andrew Jones
2020-11-09  9:14   ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z6qdy63.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=Dave.Martin@arm.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.