s805x USB broken in 5.8?

s805x USB broken in 5.8?

[Peter Korsgaard]

Hi,

I recently updated my meson-gxl-s805x-libretech-ac (la frite) board from
5.7 to 5.8, but USB seems to be broken? Given the USB phy warning, I
take it that this is related to commit 2f9139c2609fd71 (arm64: dts:
amlogic: use the new USB control driver for GXL and GXM)?

This is an unmodified 5.8.9 build of the aarch64 defconfig:

[    0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034]
[    0.000000] Linux version 5.8.9 (peko@dell) (aarch64-buildroot-linux-uclibc-gcc.br_real (Buildroot 2020.08-427-g882a8550bc-dirty) 9.3.0, GNU ld (GNU Binutils) 2.33.1) #1 SMP PREEMPT Thu Sep 17 15:02:47 CEST 2020
[    0.000000] Machine model: Libre Computer AML-S805X-AC
..
[    0.000000] Kernel command line: console=ttyAML0,115200 earlyprintk root=/dev/sda1 rootwait
..
[    1.279949] dwc3-meson-g12a d0078080.usb: USB2 ports: 2
[    1.279979] dwc3-meson-g12a d0078080.usb: USB3 ports: 0
[    1.284880] ------------[ cut here ]------------
[    1.289294] WARNING: CPU: 3 PID: 33 at drivers/reset/core.c:309 reset_control_reset+0x128/0x150
[    1.297906] Modules linked in:
[    1.300929] CPU: 3 PID: 33 Comm: kworker/3:1 Not tainted 5.8.9 #1
[    1.306962] Hardware name: Libre Computer AML-S805X-AC (DT)
[    1.312491] Workqueue: events deferred_probe_work_func
[    1.317573] pstate: 80000005 (Nzcv daif -PAN -UAO BTYPE=--)
[    1.323093] pc : reset_control_reset+0x128/0x150
[    1.327666] lr : phy_meson_gxl_usb2_init+0x1c/0x70
[    1.332405] sp : ffff800011e33ad0
[    1.335683] x29: ffff800011e33ad0 x28: ffff800011a57000
[    1.340944] x27: ffff800011dfbcc8 x26: ffff00003f027ec8
[    1.346205] x25: ffff00003f027eb0 x24: ffff00003f027eb0
[    1.351467] x23: ffff00003f56b800 x22: ffff00003f5f7400
[    1.356728] x21: ffff00003dd05308 x20: ffff00003dcf6a80
[    1.361989] x19: ffff00003dcfa380 x18: 0000000000000010
[    1.367250] x17: 00000000f4bff80b x16: 0000000000000068
[    1.372511] x15: ffff00003f56bc70 x14: ffffffffffffffff
[    1.377773] x13: ffffffff00000000 x12: ffffffffffffffff
[    1.383034] x11: 0000000000000020 x10: 7f7f7f7f7f7f7f7f
[    1.388295] x9 : fefefefefefeff30 x8 : 0000000000000000
[    1.393556] x7 : 0000000000000000 x6 : 0000000000000000
[    1.398818] x5 : 0000000000000000 x4 : 0000000000000000
[    1.404079] x3 : ffff00003dd05308 x2 : ffff8000106a50e0
[    1.409340] x1 : 0000000000000001 x0 : 0000000000000001
[    1.414602] Call trace:
[    1.417021]  reset_control_reset+0x128/0x150
[    1.421245]  phy_meson_gxl_usb2_init+0x1c/0x70
[    1.425644]  phy_init+0x74/0xd0
[    1.428752]  dwc3_meson_g12a_probe+0x2cc/0x550
[    1.433148]  platform_drv_probe+0x54/0xb0
[    1.437115]  really_probe+0xd8/0x320
[    1.440652]  driver_probe_device+0x58/0xc0
[    1.444705]  __device_attach_driver+0x84/0xd0
[    1.449018]  bus_for_each_drv+0x78/0xd0
[    1.452813]  __device_attach+0xf0/0x150
[    1.456608]  device_initial_probe+0x14/0x20
[    1.460747]  bus_probe_device+0x9c/0xb0
[    1.464543]  deferred_probe_work_func+0x74/0xb0
[    1.469030]  process_one_work+0x1b8/0x330
[    1.472995]  worker_thread+0x1f8/0x420
[    1.476704]  kthread+0x140/0x160
[    1.479897]  ret_from_fork+0x10/0x34
[    1.483430] ---[ end trace 433380d964d6069b ]---
[    1.488039] phy phy-d0078000.phy.0: phy init failed --> -22
[    1.493639] dwc3-meson-g12a: probe of d0078080.usb failed with error -22
[    1.502403] scpi_protocol scpi: SCP Protocol legacy pre-1.0 firmware
domain-0 init dvfs: 4
[    1.525880] ALSA device list:
[    1.525902]   No soundcards found.
[    1.532312] Waiting for root device /dev/sda1...

And then nothing.

I see similar issues on kernelci, E.G.:
https://storage.kernelci.org/chrome-platform/for-kernelci/v5.9-rc1-2-gf048ccd37a8b/arm64/defconfig/gcc-8/lab-baylibre/baseline-meson-gxl-s805x-libretech-ac.html

Before I dig deeper, am I missing something? Is this a known issue?

-- 
Bye, Peter Korsgaard

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: s805x USB broken in 5.8?

[Anand Moon]

Hi Peter,

On Thu, 17 Sep 2020 at 19:16, Peter Korsgaard <peter@korsgaard.com> wrote:
>
> Hi,
>
> I recently updated my meson-gxl-s805x-libretech-ac (la frite) board from
> 5.7 to 5.8, but USB seems to be broken? Given the USB phy warning, I
> take it that this is related to commit 2f9139c2609fd71 (arm64: dts:
> amlogic: use the new USB control driver for GXL and GXM)?
>
> This is an unmodified 5.8.9 build of the aarch64 defconfig:
>
> [    0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034]
> [    0.000000] Linux version 5.8.9 (peko@dell) (aarch64-buildroot-linux-uclibc-gcc.br_real (Buildroot 2020.08-427-g882a8550bc-dirty) 9.3.0, GNU ld (GNU Binutils) 2.33.1) #1 SMP PREEMPT Thu Sep 17 15:02:47 CEST 2020
> [    0.000000] Machine model: Libre Computer AML-S805X-AC
> ..
> [    0.000000] Kernel command line: console=ttyAML0,115200 earlyprintk root=/dev/sda1 rootwait
> ..
> [    1.279949] dwc3-meson-g12a d0078080.usb: USB2 ports: 2
> [    1.279979] dwc3-meson-g12a d0078080.usb: USB3 ports: 0
> [    1.284880] ------------[ cut here ]------------
> [    1.289294] WARNING: CPU: 3 PID: 33 at drivers/reset/core.c:309 reset_control_reset+0x128/0x150
> [    1.297906] Modules linked in:
> [    1.300929] CPU: 3 PID: 33 Comm: kworker/3:1 Not tainted 5.8.9 #1
> [    1.306962] Hardware name: Libre Computer AML-S805X-AC (DT)
> [    1.312491] Workqueue: events deferred_probe_work_func
> [    1.317573] pstate: 80000005 (Nzcv daif -PAN -UAO BTYPE=--)
> [    1.323093] pc : reset_control_reset+0x128/0x150
> [    1.327666] lr : phy_meson_gxl_usb2_init+0x1c/0x70
> [    1.332405] sp : ffff800011e33ad0
> [    1.335683] x29: ffff800011e33ad0 x28: ffff800011a57000
> [    1.340944] x27: ffff800011dfbcc8 x26: ffff00003f027ec8
> [    1.346205] x25: ffff00003f027eb0 x24: ffff00003f027eb0
> [    1.351467] x23: ffff00003f56b800 x22: ffff00003f5f7400
> [    1.356728] x21: ffff00003dd05308 x20: ffff00003dcf6a80
> [    1.361989] x19: ffff00003dcfa380 x18: 0000000000000010
> [    1.367250] x17: 00000000f4bff80b x16: 0000000000000068
> [    1.372511] x15: ffff00003f56bc70 x14: ffffffffffffffff
> [    1.377773] x13: ffffffff00000000 x12: ffffffffffffffff
> [    1.383034] x11: 0000000000000020 x10: 7f7f7f7f7f7f7f7f
> [    1.388295] x9 : fefefefefefeff30 x8 : 0000000000000000
> [    1.393556] x7 : 0000000000000000 x6 : 0000000000000000
> [    1.398818] x5 : 0000000000000000 x4 : 0000000000000000
> [    1.404079] x3 : ffff00003dd05308 x2 : ffff8000106a50e0
> [    1.409340] x1 : 0000000000000001 x0 : 0000000000000001
> [    1.414602] Call trace:
> [    1.417021]  reset_control_reset+0x128/0x150
> [    1.421245]  phy_meson_gxl_usb2_init+0x1c/0x70
> [    1.425644]  phy_init+0x74/0xd0
> [    1.428752]  dwc3_meson_g12a_probe+0x2cc/0x550
> [    1.433148]  platform_drv_probe+0x54/0xb0
> [    1.437115]  really_probe+0xd8/0x320
> [    1.440652]  driver_probe_device+0x58/0xc0
> [    1.444705]  __device_attach_driver+0x84/0xd0
> [    1.449018]  bus_for_each_drv+0x78/0xd0
> [    1.452813]  __device_attach+0xf0/0x150
> [    1.456608]  device_initial_probe+0x14/0x20
> [    1.460747]  bus_probe_device+0x9c/0xb0
> [    1.464543]  deferred_probe_work_func+0x74/0xb0
> [    1.469030]  process_one_work+0x1b8/0x330
> [    1.472995]  worker_thread+0x1f8/0x420
> [    1.476704]  kthread+0x140/0x160
> [    1.479897]  ret_from_fork+0x10/0x34
> [    1.483430] ---[ end trace 433380d964d6069b ]---
> [    1.488039] phy phy-d0078000.phy.0: phy init failed --> -22
> [    1.493639] dwc3-meson-g12a: probe of d0078080.usb failed with error -22
> [    1.502403] scpi_protocol scpi: SCP Protocol legacy pre-1.0 firmware
> domain-0 init dvfs: 4
> [    1.525880] ALSA device list:
> [    1.525902]   No soundcards found.
> [    1.532312] Waiting for root device /dev/sda1...
>
> And then nothing.
>
> I see similar issues on kernelci, E.G.:
> https://storage.kernelci.org/chrome-platform/for-kernelci/v5.9-rc1-2-gf048ccd37a8b/arm64/defconfig/gcc-8/lab-baylibre/baseline-meson-gxl-s805x-libretech-ac.html
>
> Before I dig deeper, am I missing something? Is this a known issue?

Yes, please try this patch.

https://patchwork.kernel.org/patch/11740801/

>
> --
> Bye, Peter Korsgaard
>

Best Regards
-Anand

> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: s805x USB broken in 5.8?

[Peter Korsgaard]

>>>>> "Anand" == Anand Moon <linux.amoon@gmail.com> writes:

 > Hi Peter,

 >> Before I dig deeper, am I missing something? Is this a known issue?

 > Yes, please try this patch.

 > https://patchwork.kernel.org/patch/11740801/

Ahh, thanks - And I see that this is now in 5.8.10, good.

-- 
Bye, Peter Korsgaard

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: s805x USB broken in 5.8?

[Anand Moon]

Hi Peter,

On Thu, 17 Sep 2020 at 21:00, Peter Korsgaard <peter@korsgaard.com> wrote:
>
> >>>>> "Anand" == Anand Moon <linux.amoon@gmail.com> writes:
>
>  > Hi Peter,
>
>  >> Before I dig deeper, am I missing something? Is this a known issue?
>
>  > Yes, please try this patch.
>
>  > https://patchwork.kernel.org/patch/11740801/
>
> Ahh, thanks - And I see that this is now in 5.8.10, good.
>
> --
> Bye, Peter Korsgaard

Can you share the instructions on how to build an image using buildroot?.
I need to do some testing of some features in the future.

Best Regards
-Anand

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: s805x USB broken in 5.8?

[Peter Korsgaard]

>>>>> "Anand" == Anand Moon <linux.amoon@gmail.com> writes:

Hi,

 > Can you share the instructions on how to build an image using buildroot?.
 > I need to do some testing of some features in the future.

Sure. Have a look at the lafrite defconfig and readme we have:

https://git.buildroot.net/buildroot/tree/board/librecomputer/lafrite/readme.txt
https://git.buildroot.net/buildroot/tree/configs/lafrite_defconfig

You may want to change to a prebuilt toolchain to speed up the build
(make menuconfig -> toolchain -> toolchain type -> external toolchain).

-- 
Bye, Peter Korsgaard

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: s805x USB broken in 5.8?

[Anand Moon]

Hi Peter,

On Sat, 19 Sep 2020 at 15:02, Peter Korsgaard <peter@korsgaard.com> wrote:
>
> >>>>> "Anand" == Anand Moon <linux.amoon@gmail.com> writes:
>
> Hi,
>
>  > Can you share the instructions on how to build an image using buildroot?.
>  > I need to do some testing of some features in the future.
>
> Sure. Have a look at the lafrite defconfig and readme we have:
>
> https://git.buildroot.net/buildroot/tree/board/librecomputer/lafrite/readme.txt
> https://git.buildroot.net/buildroot/tree/configs/lafrite_defconfig
>
> You may want to change to a prebuilt toolchain to speed up the build
> (make menuconfig -> toolchain -> toolchain type -> external toolchain).
>
> --
> Bye, Peter Korsgaard

Thanks for the quick response.
I will give this a try on my SBC.

Best Regards
-Anand

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: s805x USB broken in 5.8?

[Peter Korsgaard]

>>>>> "Anand" == Anand Moon <linux.amoon@gmail.com> writes:

 >> Sure. Have a look at the lafrite defconfig and readme we have:
 >> 
 >> https://git.buildroot.net/buildroot/tree/board/librecomputer/lafrite/readme.txt
 >> https://git.buildroot.net/buildroot/tree/configs/lafrite_defconfig
 >> 
 >> You may want to change to a prebuilt toolchain to speed up the build
 >> (make menuconfig -> toolchain -> toolchain type -> external toolchain).

 > Thanks for the quick response.
 > I will give this a try on my SBC.

Out of interest, what SBC are you using? A lafrite?

-- 
Bye, Peter Korsgaard

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: s805x USB broken in 5.8?

[Anand Moon]

Hi Perter,

On Sat, 19 Sep 2020 at 15:31, Peter Korsgaard <peter@korsgaard.com> wrote:
>
> >>>>> "Anand" == Anand Moon <linux.amoon@gmail.com> writes:
>
>  >> Sure. Have a look at the lafrite defconfig and readme we have:
>  >>
>  >> https://git.buildroot.net/buildroot/tree/board/librecomputer/lafrite/readme.txt
>  >> https://git.buildroot.net/buildroot/tree/configs/lafrite_defconfig
>  >>
>  >> You may want to change to a prebuilt toolchain to speed up the build
>  >> (make menuconfig -> toolchain -> toolchain type -> external toolchain).
>
>  > Thanks for the quick response.
>  > I will give this a try on my SBC.
>
> Out of interest, what SBC are you using? A lafrite?
>

I have an odroid C2 / C4 / N2/  Le Potato.

> --
> Bye, Peter Korsgaard

Best Regards
-Anand

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic