All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] i915: Expose panel power cycle delay to i915_panel_timings
Date: Thu, 28 Nov 2019 16:05:03 +0200	[thread overview]
Message-ID: <875zj4m700.fsf@intel.com> (raw)
In-Reply-To: <20191118163339.16825-1-anshuman.gupta@intel.com>

On Mon, 18 Nov 2019, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
> Putting down the AUX power domain reference count in
> edp vdd off async sequence takes too much of time
> (relative to panel power cycle delay) therefore it make sense
> to expose the panel power cycle delay to i915_panel_timings
> along with other delays.
> It can be use by DC state IGT to wait for strict power cycle delay
> in order to check for various DC state counters.

Catching up on review, are you suggesting to look at this kind of
debugfs files for tests? Please find another way.

I don't mind having the debugfs info per se.

BR,
Jani.

>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index cab632791f73..c075cc2b7bb5 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4436,6 +4436,8 @@ static int i915_panel_show(struct seq_file *m, void *data)
>  		   intel_dp->panel_power_up_delay);
>  	seq_printf(m, "Panel power down delay: %d\n",
>  		   intel_dp->panel_power_down_delay);
> +	seq_printf(m, "Panel power cycle delay: %d\n",
> +		   intel_dp->panel_power_cycle_delay);
>  	seq_printf(m, "Backlight on delay: %d\n",
>  		   intel_dp->backlight_on_delay);
>  	seq_printf(m, "Backlight off delay: %d\n",

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] i915: Expose panel power cycle delay to i915_panel_timings
Date: Thu, 28 Nov 2019 16:05:03 +0200	[thread overview]
Message-ID: <875zj4m700.fsf@intel.com> (raw)
Message-ID: <20191128140503.NIul89s2TThbjqJWSaEo8svrV8yPQjNMKeuoyOQNGyw@z> (raw)
In-Reply-To: <20191118163339.16825-1-anshuman.gupta@intel.com>

On Mon, 18 Nov 2019, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
> Putting down the AUX power domain reference count in
> edp vdd off async sequence takes too much of time
> (relative to panel power cycle delay) therefore it make sense
> to expose the panel power cycle delay to i915_panel_timings
> along with other delays.
> It can be use by DC state IGT to wait for strict power cycle delay
> in order to check for various DC state counters.

Catching up on review, are you suggesting to look at this kind of
debugfs files for tests? Please find another way.

I don't mind having the debugfs info per se.

BR,
Jani.

>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index cab632791f73..c075cc2b7bb5 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4436,6 +4436,8 @@ static int i915_panel_show(struct seq_file *m, void *data)
>  		   intel_dp->panel_power_up_delay);
>  	seq_printf(m, "Panel power down delay: %d\n",
>  		   intel_dp->panel_power_down_delay);
> +	seq_printf(m, "Panel power cycle delay: %d\n",
> +		   intel_dp->panel_power_cycle_delay);
>  	seq_printf(m, "Backlight on delay: %d\n",
>  		   intel_dp->backlight_on_delay);
>  	seq_printf(m, "Backlight off delay: %d\n",

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-28 14:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 16:33 [PATCH] i915: Expose panel power cycle delay to i915_panel_timings Anshuman Gupta
2019-11-18 16:33 ` [Intel-gfx] " Anshuman Gupta
2019-11-18 19:08 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-18 19:08   ` [Intel-gfx] " Patchwork
2019-11-28 14:05 ` Jani Nikula [this message]
2019-11-28 14:05   ` [Intel-gfx] [PATCH] " Jani Nikula
2019-12-03  6:13   ` Anshuamn Gupta
2019-12-03  6:13     ` [Intel-gfx] " Anshuamn Gupta
2019-12-03  7:59     ` Jani Nikula
2019-12-03  7:59       ` [Intel-gfx] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zj4m700.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.