[wireless-drivers-next:master 89/97] drivers/net/wireless/realtek/rtw88/rtw8822b.c:1440:6: sparse: sparse: symbol 'rtw8822b_pwr_track' was not declared. Should it be static?

[wireless-drivers-next:master 89/97] drivers/net/wireless/realtek/rtw88/rtw8822b.c:1440:6: sparse: sparse: symbol 'rtw8822b_pwr_track' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
head:   b298800dd8ee7250bf04b4dbd151e1a971b6df91
commit: c97ee3e0bea29827f4b44276fc792bd32977edb0 [89/97] rtw88: add power tracking support
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-dirty
        git checkout c97ee3e0bea29827f4b44276fc792bd32977edb0
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/net/wireless/realtek/rtw88/rtw8822b.c:1440:6: sparse: sparse: symbol 'rtw8822b_pwr_track' was not declared. Should it be static?
--
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1008:6: sparse: sparse: symbol 'rtw8822c_pwrtrack_init' was not declared. Should it be static?
   drivers/net/wireless/realtek/rtw88/rtw8822c.c:2871:6: sparse: sparse: symbol 'rtw8822c_dpk_cal_coef1' was not declared. Should it be static?
   drivers/net/wireless/realtek/rtw88/rtw8822c.c:3112:6: sparse: sparse: symbol 'rtw8822c_dpk_track' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH wireless-drivers-next] rtw88: rtw8822b_pwr_track() can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]


Fixes: c97ee3e0bea2 ("rtw88: add power tracking support")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 rtw8822b.c |    2 +-
 rtw8822c.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
index 34fbfe6b4a119..5a599083c9588 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
@@ -1437,7 +1437,7 @@ static void rtw8822b_phy_pwrtrack(struct rtw_dev *rtwdev)
 		rtw8822b_do_iqk(rtwdev);
 }
 
-void rtw8822b_pwr_track(struct rtw_dev *rtwdev)
+static void rtw8822b_pwr_track(struct rtw_dev *rtwdev)
 {
 	struct rtw_efuse *efuse = &rtwdev->efuse;
 	struct rtw_dm_info *dm_info = &rtwdev->dm_info;
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index 21c2d9e651fe5..1cebb07de3bb8 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -1005,7 +1005,7 @@ static void rtw8822c_rf_init(struct rtw_dev *rtwdev)
 	rtw8822c_rf_x2_check(rtwdev);
 }
 
-void rtw8822c_pwrtrack_init(struct rtw_dev *rtwdev)
+static void rtw8822c_pwrtrack_init(struct rtw_dev *rtwdev)
 {
 	struct rtw_dm_info *dm_info = &rtwdev->dm_info;
 	u8 path;

Re: [wireless-drivers-next:master 89/97] drivers/net/wireless/realtek/rtw88/rtw8822b.c:1440:6: sparse: sparse: symbol 'rtw8822b_pwr_track' was not declared. Should it be static?

[Kalle Valo]

+ linux-wireless

Tony, can you send a followup patch to fix this as well?

Kalle

kbuild test robot <lkp@intel.com> writes:

> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
> master
> head:   b298800dd8ee7250bf04b4dbd151e1a971b6df91
> commit: c97ee3e0bea29827f4b44276fc792bd32977edb0 [89/97] rtw88: add power tracking support
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.1-dirty
>         git checkout c97ee3e0bea29827f4b44276fc792bd32977edb0
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/net/wireless/realtek/rtw88/rtw8822b.c:1440:6: sparse:
> sparse: symbol 'rtw8822b_pwr_track' was not declared. Should it be
> static?
> --
>>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1008:6: sparse: sparse: symbol 'rtw8822c_pwrtrack_init' was not declared. Should it be static?
>    drivers/net/wireless/realtek/rtw88/rtw8822c.c:2871:6: sparse: sparse: symbol 'rtw8822c_dpk_cal_coef1' was not declared. Should it be static?
>    drivers/net/wireless/realtek/rtw88/rtw8822c.c:3112:6: sparse: sparse: symbol 'rtw8822c_dpk_track' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

-- 
Kalle Valo

Re: [wireless-drivers-next:master 89/97] drivers/net/wireless/realtek/rtw88/rtw8822b.c:1440:6: sparse: sparse: symbol 'rtw8822b_pwr_track' was not declared. Should it be static?

[Kalle Valo]

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

+ linux-wireless

Tony, can you send a followup patch to fix this as well?

Kalle

kbuild test robot <lkp@intel.com> writes:

> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
> master
> head:   b298800dd8ee7250bf04b4dbd151e1a971b6df91
> commit: c97ee3e0bea29827f4b44276fc792bd32977edb0 [89/97] rtw88: add power tracking support
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.1-dirty
>         git checkout c97ee3e0bea29827f4b44276fc792bd32977edb0
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/net/wireless/realtek/rtw88/rtw8822b.c:1440:6: sparse:
> sparse: symbol 'rtw8822b_pwr_track' was not declared. Should it be
> static?
> --
>>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1008:6: sparse: sparse: symbol 'rtw8822c_pwrtrack_init' was not declared. Should it be static?
>    drivers/net/wireless/realtek/rtw88/rtw8822c.c:2871:6: sparse: sparse: symbol 'rtw8822c_dpk_cal_coef1' was not declared. Should it be static?
>    drivers/net/wireless/realtek/rtw88/rtw8822c.c:3112:6: sparse: sparse: symbol 'rtw8822c_dpk_track' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

-- 
Kalle Valo