From: Kalle Valo <kvalo@codeaurora.org>
To: Mao Wenan <maowenan@huawei.com>
Cc: johannes.berg@intel.com, emmanuel.grumbach@intel.com,
luciano.coelho@intel.com, linuxwifi@intel.com,
davem@davemloft.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] iwlwifi: add dependency of THERMAL with IWLMVM
Date: Wed, 18 Sep 2019 13:08:51 +0000 [thread overview]
Message-ID: <875zlpbvks.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190918122815.155657-1-maowenan@huawei.com> (Mao Wenan's message of "Wed, 18 Sep 2019 20:28:15 +0800")
Mao Wenan <maowenan@huawei.com> writes:
> If CONFIG_IWLMVM=y, CONFIG_THERMAL=n, below error can be found:
> drivers/net/wireless/intel/iwlwifi/mvm/fw.o: In function `iwl_mvm_up':
> fw.c:(.text+0x2c26): undefined reference to `iwl_mvm_send_temp_report_ths_cmd'
> make: *** [vmlinux] Error 1
>
> After commit 242d9c8b9a93 ("iwlwifi: mvm: use FW thermal
> monitoring regardless of CONFIG_THERMAL"), iwl_mvm_up()
> calls iwl_mvm_send_temp_report_ths_cmd(), but this function
> is under CONFIG_THERMAL, which is depended on CONFIG_THERMAL.
>
> Fixes: 242d9c8b9a93 ("iwlwifi: mvm: use FW thermal monitoring regardless of CONFIG_THERMAL")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Luca, should I apply this directly to wireless-drivers?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Mao Wenan <maowenan@huawei.com>
Cc: <johannes.berg@intel.com>, <emmanuel.grumbach@intel.com>,
<luciano.coelho@intel.com>, <linuxwifi@intel.com>,
<davem@davemloft.net>, <linux-wireless@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH net] iwlwifi: add dependency of THERMAL with IWLMVM
Date: Wed, 18 Sep 2019 16:08:51 +0300 [thread overview]
Message-ID: <875zlpbvks.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190918122815.155657-1-maowenan@huawei.com> (Mao Wenan's message of "Wed, 18 Sep 2019 20:28:15 +0800")
Mao Wenan <maowenan@huawei.com> writes:
> If CONFIG_IWLMVM=y, CONFIG_THERMAL=n, below error can be found:
> drivers/net/wireless/intel/iwlwifi/mvm/fw.o: In function `iwl_mvm_up':
> fw.c:(.text+0x2c26): undefined reference to `iwl_mvm_send_temp_report_ths_cmd'
> make: *** [vmlinux] Error 1
>
> After commit 242d9c8b9a93 ("iwlwifi: mvm: use FW thermal
> monitoring regardless of CONFIG_THERMAL"), iwl_mvm_up()
> calls iwl_mvm_send_temp_report_ths_cmd(), but this function
> is under CONFIG_THERMAL, which is depended on CONFIG_THERMAL.
>
> Fixes: 242d9c8b9a93 ("iwlwifi: mvm: use FW thermal monitoring regardless of CONFIG_THERMAL")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Luca, should I apply this directly to wireless-drivers?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-09-18 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 12:28 [PATCH net] iwlwifi: add dependency of THERMAL with IWLMVM Mao Wenan
2019-09-18 12:28 ` Mao Wenan
2019-09-18 13:08 ` Kalle Valo [this message]
2019-09-18 13:08 ` Kalle Valo
2019-09-18 13:17 ` Luciano Coelho
2019-09-18 13:17 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zlpbvks.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=maowenan@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.