From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines
Date: Thu, 12 Jul 2018 14:04:12 +0200 [thread overview]
Message-ID: <87601koe2r.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <5d0c7195-ffbf-1618-6106-ef6c82df3bd7@redhat.com> (Thomas Huth's message of "Tue, 10 Jul 2018 00:03:39 +0200")
Thomas Huth <thuth@redhat.com> writes:
> On 09.07.2018 23:42, Peter Maydell wrote:
>> On 9 July 2018 at 22:03, Thomas Huth <thuth@redhat.com> wrote:
[...]
> Hmm, maybe we need a qtest that first executes "info qtree", then runs
> 'device-list-properties' for all devices and finally checks "info qtree"
> again ... since 'device-list-properties' should not change the qtree,
> the output of the "info qtree" should be the same.
Lovely idea.
> Currently this is not
> the case :-/
Less than lovely, but I can't claim to be surprised. As Peter remarked
elsewhere in this thread, QOM is underdocumented, and is too easy to
misuse.
On documentation: we sorely lack documentation tying everything
together. GDK-Doc function comments alone can't cut it for something as
complex as QOM.
Even with adequate documentation, bad examples in the source will
continue to multiply. We'll have to get rid of them.
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines
Date: Thu, 12 Jul 2018 14:04:12 +0200 [thread overview]
Message-ID: <87601koe2r.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <5d0c7195-ffbf-1618-6106-ef6c82df3bd7@redhat.com> (Thomas Huth's message of "Tue, 10 Jul 2018 00:03:39 +0200")
Thomas Huth <thuth@redhat.com> writes:
> On 09.07.2018 23:42, Peter Maydell wrote:
>> On 9 July 2018 at 22:03, Thomas Huth <thuth@redhat.com> wrote:
[...]
> Hmm, maybe we need a qtest that first executes "info qtree", then runs
> 'device-list-properties' for all devices and finally checks "info qtree"
> again ... since 'device-list-properties' should not change the qtree,
> the output of the "info qtree" should be the same.
Lovely idea.
> Currently this is not
> the case :-/
Less than lovely, but I can't claim to be surprised. As Peter remarked
elsewhere in this thread, QOM is underdocumented, and is too easy to
misuse.
On documentation: we sorely lack documentation tying everything
together. GDK-Doc function comments alone can't cut it for something as
complex as QOM.
Even with adequate documentation, bad examples in the source will
continue to multiply. We'll have to get rid of them.
next prev parent reply other threads:[~2018-07-12 12:04 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 21:03 [Qemu-arm] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines Thomas Huth
2018-07-09 21:03 ` [Qemu-devel] " Thomas Huth
2018-07-09 21:31 ` [Qemu-arm] " Eduardo Habkost
2018-07-09 21:31 ` [Qemu-devel] " Eduardo Habkost
2018-07-09 21:36 ` [Qemu-arm] " Thomas Huth
2018-07-09 21:36 ` [Qemu-devel] " Thomas Huth
2018-07-09 21:42 ` [Qemu-arm] " Peter Maydell
2018-07-09 21:42 ` [Qemu-devel] " Peter Maydell
2018-07-09 22:03 ` [Qemu-arm] " Thomas Huth
2018-07-09 22:03 ` [Qemu-devel] " Thomas Huth
2018-07-10 6:50 ` [Qemu-arm] " Peter Maydell
2018-07-10 6:50 ` [Qemu-devel] " Peter Maydell
2018-07-11 7:21 ` [Qemu-arm] " Thomas Huth
2018-07-11 7:21 ` [Qemu-devel] " Thomas Huth
2018-07-11 16:12 ` [Qemu-arm] " Eduardo Habkost
2018-07-11 16:12 ` [Qemu-devel] " Eduardo Habkost
2018-07-11 17:15 ` [Qemu-arm] " Peter Maydell
2018-07-11 17:15 ` [Qemu-devel] " Peter Maydell
2018-07-12 12:06 ` [Qemu-arm] " Markus Armbruster
2018-07-12 12:06 ` Markus Armbruster
2018-07-12 12:55 ` [Qemu-arm] " Peter Maydell
2018-07-12 12:55 ` Peter Maydell
2018-07-12 13:19 ` [Qemu-arm] " Markus Armbruster
2018-07-12 13:19 ` Markus Armbruster
2018-07-12 15:25 ` [Qemu-arm] " Thomas Huth
2018-07-12 15:25 ` Thomas Huth
2018-07-12 16:16 ` [Qemu-arm] " Markus Armbruster
2018-07-12 16:16 ` Markus Armbruster
2018-07-12 16:22 ` [Qemu-arm] " Peter Maydell
2018-07-12 16:22 ` Peter Maydell
2018-07-12 16:32 ` Thomas Huth
2018-07-16 6:41 ` [Qemu-arm] " Markus Armbruster
2018-07-16 6:41 ` Markus Armbruster
2018-07-11 17:21 ` [Qemu-arm] " Paolo Bonzini
2018-07-11 17:21 ` [Qemu-devel] " Paolo Bonzini
2018-07-11 19:04 ` [Qemu-arm] " Thomas Huth
2018-07-11 19:04 ` [Qemu-devel] " Thomas Huth
2018-07-11 19:59 ` [Qemu-arm] " Eduardo Habkost
2018-07-11 19:59 ` [Qemu-devel] " Eduardo Habkost
2018-07-12 8:04 ` [Qemu-arm] " Paolo Bonzini
2018-07-12 8:04 ` Paolo Bonzini
2018-07-12 12:04 ` Markus Armbruster [this message]
2018-07-12 12:04 ` Markus Armbruster
2018-07-11 17:20 ` [Qemu-arm] " Paolo Bonzini
2018-07-11 17:20 ` [Qemu-devel] " Paolo Bonzini
2018-07-11 18:30 ` [Qemu-arm] " Eduardo Habkost
2018-07-11 18:30 ` [Qemu-devel] " Eduardo Habkost
2018-07-11 20:16 ` [Qemu-arm] " Paolo Bonzini
2018-07-11 20:16 ` [Qemu-devel] " Paolo Bonzini
2018-07-11 20:23 ` [Qemu-arm] " Eduardo Habkost
2018-07-11 20:23 ` [Qemu-devel] " Eduardo Habkost
2018-07-12 8:05 ` Paolo Bonzini
2018-07-12 18:04 ` [Qemu-arm] " Eduardo Habkost
2018-07-12 18:04 ` Eduardo Habkost
2018-07-16 6:43 ` [Qemu-arm] " Markus Armbruster
2018-07-16 6:43 ` Markus Armbruster
2018-07-16 14:25 ` [Qemu-arm] " Eduardo Habkost
2018-07-16 14:25 ` Eduardo Habkost
2018-07-11 18:43 ` [Qemu-arm] " Thomas Huth
2018-07-11 18:43 ` [Qemu-devel] " Thomas Huth
2018-07-11 20:15 ` [Qemu-arm] " Paolo Bonzini
2018-07-11 20:15 ` [Qemu-devel] " Paolo Bonzini
2018-07-12 5:57 ` [Qemu-arm] " Thomas Huth
2018-07-12 5:57 ` [Qemu-devel] " Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87601koe2r.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.