* [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
@ 2018-01-17 11:40 ` Wei Yongjun
0 siblings, 0 replies; 12+ messages in thread
From: Wei Yongjun @ 2018-01-17 11:40 UTC (permalink / raw)
To: linux-arm-kernel
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/char/hw_random/bcm2835-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
index 25e5631..7a84cec 100644
--- a/drivers/char/hw_random/bcm2835-rng.c
+++ b/drivers/char/hw_random/bcm2835-rng.c
@@ -158,10 +158,8 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
/* map peripheral */
priv->base = devm_ioremap_resource(dev, r);
- if (IS_ERR(priv->base)) {
- dev_err(dev, "failed to remap rng regs");
+ if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
- }
/* Clock is optional on most platforms */
priv->clk = devm_clk_get(dev, NULL);
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
@ 2018-01-17 11:40 ` Wei Yongjun
0 siblings, 0 replies; 12+ messages in thread
From: Wei Yongjun @ 2018-01-17 11:40 UTC (permalink / raw)
To: Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
Florian Fainelli, Ray Jui, Scott Branden, Eric Anholt,
Stefan Wahren
Cc: Wei Yongjun, bcm-kernel-feedback-list, linux-crypto,
linux-rpi-kernel, linux-arm-kernel, kernel-janitors
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/char/hw_random/bcm2835-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
index 25e5631..7a84cec 100644
--- a/drivers/char/hw_random/bcm2835-rng.c
+++ b/drivers/char/hw_random/bcm2835-rng.c
@@ -158,10 +158,8 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
/* map peripheral */
priv->base = devm_ioremap_resource(dev, r);
- if (IS_ERR(priv->base)) {
- dev_err(dev, "failed to remap rng regs");
+ if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
- }
/* Clock is optional on most platforms */
priv->clk = devm_clk_get(dev, NULL);
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
@ 2018-01-17 11:40 ` Wei Yongjun
0 siblings, 0 replies; 12+ messages in thread
From: Wei Yongjun @ 2018-01-17 11:40 UTC (permalink / raw)
To: linux-arm-kernel
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/char/hw_random/bcm2835-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
index 25e5631..7a84cec 100644
--- a/drivers/char/hw_random/bcm2835-rng.c
+++ b/drivers/char/hw_random/bcm2835-rng.c
@@ -158,10 +158,8 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
/* map peripheral */
priv->base = devm_ioremap_resource(dev, r);
- if (IS_ERR(priv->base)) {
- dev_err(dev, "failed to remap rng regs");
+ if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
- }
/* Clock is optional on most platforms */
priv->clk = devm_clk_get(dev, NULL);
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
2018-01-17 11:40 ` Wei Yongjun
(?)
@ 2018-01-17 19:47 ` Eric Anholt
-1 siblings, 0 replies; 12+ messages in thread
From: Eric Anholt @ 2018-01-17 19:47 UTC (permalink / raw)
To: linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
Wei Yongjun <weiyongjun1@huawei.com> writes:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
@ 2018-01-17 19:47 ` Eric Anholt
0 siblings, 0 replies; 12+ messages in thread
From: Eric Anholt @ 2018-01-17 19:47 UTC (permalink / raw)
To: Wei Yongjun, Matt Mackall, Herbert Xu, Arnd Bergmann,
Greg Kroah-Hartman, Florian Fainelli, Ray Jui, Scott Branden,
Stefan Wahren
Cc: Wei Yongjun, bcm-kernel-feedback-list, linux-crypto,
linux-rpi-kernel, linux-arm-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
Wei Yongjun <weiyongjun1@huawei.com> writes:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
@ 2018-01-17 19:47 ` Eric Anholt
0 siblings, 0 replies; 12+ messages in thread
From: Eric Anholt @ 2018-01-17 19:47 UTC (permalink / raw)
To: linux-arm-kernel
Wei Yongjun <weiyongjun1@huawei.com> writes:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Reviewed-by: Eric Anholt <eric@anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180117/5bab1230/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
2018-01-17 11:40 ` Wei Yongjun
(?)
@ 2018-01-22 23:09 ` Florian Fainelli
-1 siblings, 0 replies; 12+ messages in thread
From: Florian Fainelli @ 2018-01-22 23:09 UTC (permalink / raw)
To: linux-arm-kernel
On 01/17/2018 03:40 AM, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
@ 2018-01-22 23:09 ` Florian Fainelli
0 siblings, 0 replies; 12+ messages in thread
From: Florian Fainelli @ 2018-01-22 23:09 UTC (permalink / raw)
To: Wei Yongjun, Matt Mackall, Herbert Xu, Arnd Bergmann,
Greg Kroah-Hartman, Florian Fainelli, Ray Jui, Scott Branden,
Eric Anholt, Stefan Wahren
Cc: bcm-kernel-feedback-list, linux-crypto, linux-rpi-kernel,
linux-arm-kernel, kernel-janitors
On 01/17/2018 03:40 AM, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
@ 2018-01-22 23:09 ` Florian Fainelli
0 siblings, 0 replies; 12+ messages in thread
From: Florian Fainelli @ 2018-01-22 23:09 UTC (permalink / raw)
To: linux-arm-kernel
On 01/17/2018 03:40 AM, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
2018-01-17 11:40 ` Wei Yongjun
(?)
@ 2018-01-26 15:45 ` Herbert Xu
-1 siblings, 0 replies; 12+ messages in thread
From: Herbert Xu @ 2018-01-26 15:45 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 17, 2018 at 11:40:34AM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
@ 2018-01-26 15:45 ` Herbert Xu
0 siblings, 0 replies; 12+ messages in thread
From: Herbert Xu @ 2018-01-26 15:45 UTC (permalink / raw)
To: Wei Yongjun
Cc: Stefan Wahren, Florian Fainelli, Arnd Bergmann, Scott Branden,
Greg Kroah-Hartman, Matt Mackall, kernel-janitors, Eric Anholt,
bcm-kernel-feedback-list, linux-crypto, Ray Jui, linux-arm-kernel,
linux-rpi-kernel
On Wed, Jan 17, 2018 at 11:40:34AM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
@ 2018-01-26 15:45 ` Herbert Xu
0 siblings, 0 replies; 12+ messages in thread
From: Herbert Xu @ 2018-01-26 15:45 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 17, 2018 at 11:40:34AM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-01-26 15:45 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-17 11:40 [PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe() Wei Yongjun
2018-01-17 11:40 ` Wei Yongjun
2018-01-17 11:40 ` Wei Yongjun
2018-01-17 19:47 ` Eric Anholt
2018-01-17 19:47 ` Eric Anholt
2018-01-17 19:47 ` Eric Anholt
2018-01-22 23:09 ` Florian Fainelli
2018-01-22 23:09 ` Florian Fainelli
2018-01-22 23:09 ` Florian Fainelli
2018-01-26 15:45 ` Herbert Xu
2018-01-26 15:45 ` Herbert Xu
2018-01-26 15:45 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.