From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl
Date: Wed, 09 Aug 2017 13:58:01 +0300 [thread overview]
Message-ID: <8760dx57pi.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20170809101337.29391-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> ==24749== Syscall param ioctl(generic) points to uninitialised byte(s)
> ==24749== at 0x6A8ADC7: ioctl (syscall-template.S:84)
> ==24749== by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0)
> ==24749== by 0x138531: kmstest_set_connector_dpms (igt_kms.c:1022)
> ==24749== by 0x112937: set_dpms (kms_flip.c:263)
> ==24749== by 0x112937: run_test_step (kms_flip.c:776)
> ==24749== by 0x112937: event_loop (kms_flip.c:1138)
> ==24749== by 0x115468: run_test_on_crtc_set (kms_flip.c:1378)
> ==24749== by 0x115468: run_test (kms_flip.c:1450)
> ==24749== by 0x1111CF: main (kms_flip.c:1673)
> ==24749== Address 0x1ffefff2a0 is on thread 1's stack
> ==24749== in frame #2, created by kmstest_set_connector_dpms (igt_kms.c:1012)
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> lib/igt_kms.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 9fe800d1..0c6dbf74 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1014,11 +1014,10 @@ void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode)
> bool found_it = false;
>
> for (i = 0; i < connector->count_props; i++) {
> - struct drm_mode_get_property prop;
> + struct drm_mode_get_property prop = {
> + .prop_id = connector->props[i],
> + };
>
> - prop.prop_id = connector->props[i];
> - prop.count_values = 0;
> - prop.count_enum_blobs = 0;
> if (drmIoctl(fd, DRM_IOCTL_MODE_GETPROPERTY, &prop))
> continue;
>
> --
> 2.13.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-09 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 10:13 [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl Chris Wilson
2017-08-09 10:58 ` Mika Kuoppala [this message]
2017-08-09 12:37 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760dx57pi.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.