From: Keith Packard <keithp@keithp.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns
Date: Tue, 25 Jul 2017 13:54:46 -0700 [thread overview]
Message-ID: <8760egutih.fsf@keithp.com> (raw)
In-Reply-To: <20170707121640.4oedsdmpwhi4neyj@phenom.ffwll.local>
[-- Attachment #1.1: Type: text/plain, Size: 1040 bytes --]
Daniel Vetter <daniel@ffwll.ch> writes:
> I'd drop that part (but keep 64 everywhere else ofc).
Yeah, we only ever ask drivers for a delta anyways, so keeping an
internal 64-bit value while retaining the 32-bit driver API is
easy to manage.
>> > Other thought on this, since you bother to change all the types: Afaik
>> > both timespec and timeval suffer from the 32bit issues.
>>
>> I'm not sure what 32bit issues you're concerned about here? We don't
>> compare these values, just report them up to user space.
>
> Year 2038 32bit wrap-around bug. Yes I believe/fear drm will still be
> around then :-)
A fine point. I've switched to ktime_t, which has additional benefits in
making the internal interfaces a bit cleaner with pass-by-value possible
in more cases now.
I've pushed incremental patches out for all of the suggested changes to
my drm-sequence-64 branch. I think I'll send those out as incremental
patches and then also send out a squashed version from the original
branch point.
--
-keith
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Keith Packard <keithp@keithp.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns
Date: Tue, 25 Jul 2017 13:54:46 -0700 [thread overview]
Message-ID: <8760egutih.fsf@keithp.com> (raw)
In-Reply-To: <20170707121640.4oedsdmpwhi4neyj@phenom.ffwll.local>
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
Daniel Vetter <daniel@ffwll.ch> writes:
> I'd drop that part (but keep 64 everywhere else ofc).
Yeah, we only ever ask drivers for a delta anyways, so keeping an
internal 64-bit value while retaining the 32-bit driver API is
easy to manage.
>> > Other thought on this, since you bother to change all the types: Afaik
>> > both timespec and timeval suffer from the 32bit issues.
>>
>> I'm not sure what 32bit issues you're concerned about here? We don't
>> compare these values, just report them up to user space.
>
> Year 2038 32bit wrap-around bug. Yes I believe/fear drm will still be
> around then :-)
A fine point. I've switched to ktime_t, which has additional benefits in
making the internal interfaces a bit cleaner with pass-by-value possible
in more cases now.
I've pushed incremental patches out for all of the suggested changes to
my drm-sequence-64 branch. I think I'll send those out as incremental
patches and then also send out a squashed version from the original
branch point.
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-07-25 20:54 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 22:10 [PATCH 0/3] drm: Add CRTC-id based ioctls for vblank query/event Keith Packard
2017-07-05 22:10 ` Keith Packard
2017-07-05 22:10 ` [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns Keith Packard
2017-07-05 22:10 ` Keith Packard
2017-07-06 7:19 ` Daniel Vetter
2017-07-06 7:19 ` Daniel Vetter
2017-07-06 14:59 ` Keith Packard
2017-07-06 14:59 ` Keith Packard
2017-07-07 12:16 ` Daniel Vetter
2017-07-07 12:16 ` Daniel Vetter
2017-07-25 20:54 ` Keith Packard [this message]
2017-07-25 20:54 ` Keith Packard
2017-07-06 7:45 ` Michel Dänzer
2017-07-06 7:45 ` Michel Dänzer
2017-07-06 8:05 ` Michel Dänzer
2017-07-06 8:05 ` Michel Dänzer
2017-07-06 15:11 ` Keith Packard
2017-07-06 15:04 ` Keith Packard
2017-07-06 15:04 ` Keith Packard
2017-07-07 1:34 ` Michel Dänzer
2017-07-07 1:34 ` Michel Dänzer
2017-07-07 2:05 ` Michel Dänzer
2017-07-07 2:05 ` Michel Dänzer
2017-07-05 22:10 ` [PATCH 2/3] drm: Reorganize drm_pending_event to support future event types Keith Packard
2017-07-05 22:10 ` Keith Packard
2017-07-06 7:30 ` Daniel Vetter
2017-07-06 15:36 ` Keith Packard
2017-07-06 15:36 ` Keith Packard
2017-07-07 12:05 ` Daniel Vetter
2017-07-07 12:05 ` Daniel Vetter
2017-07-05 22:10 ` [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls Keith Packard
2017-07-05 22:10 ` Keith Packard
2017-07-06 7:53 ` Daniel Vetter
2017-07-06 10:16 ` Ville Syrjälä
2017-07-06 10:16 ` Ville Syrjälä
2017-07-06 11:04 ` Daniel Vetter
2017-07-06 14:08 ` Ville Syrjälä
2017-07-06 16:28 ` Keith Packard
2017-07-06 16:28 ` Keith Packard
2017-07-06 17:59 ` Ville Syrjälä
2017-07-06 17:59 ` Ville Syrjälä
2017-07-06 18:22 ` Keith Packard
2017-07-06 18:22 ` Keith Packard
2017-07-06 18:59 ` Ville Syrjälä
2017-07-06 18:59 ` Ville Syrjälä
2017-07-06 19:46 ` Keith Packard
2017-07-06 19:46 ` Keith Packard
2017-07-06 16:27 ` Keith Packard
2017-07-06 16:27 ` Keith Packard
2017-07-06 21:49 ` Daniel Vetter
2017-07-06 21:49 ` Daniel Vetter
2017-08-01 5:03 ` [PATCH 0/3] drm: Add CRTC-id based ioctls for vblank query/event Keith Packard
2017-08-01 5:03 ` Keith Packard
2017-08-01 5:03 ` [PATCH 1/3] drm: Widen vblank UAPI to 64 bits. Change vblank time to ktime_t [v2] Keith Packard
2017-08-01 5:03 ` Keith Packard
2017-08-02 8:53 ` Daniel Vetter
2017-08-02 8:53 ` Daniel Vetter
2017-08-02 9:41 ` Michel Dänzer
2017-08-02 9:41 ` Michel Dänzer
2017-08-06 17:35 ` Keith Packard
2017-08-06 17:35 ` Keith Packard
2017-08-01 5:03 ` [PATCH 2/3] drm: Reorganize drm_pending_event to support future event types [v2] Keith Packard
2017-08-02 9:05 ` Daniel Vetter
2017-08-01 5:03 ` [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls [v2] Keith Packard
2017-08-01 5:03 ` Keith Packard
2017-08-02 9:25 ` Daniel Vetter
2017-08-02 9:25 ` Daniel Vetter
2017-08-06 3:32 ` Keith Packard
2017-08-06 3:32 ` Keith Packard
2017-08-07 3:02 ` Michel Dänzer
2017-08-07 3:02 ` Michel Dänzer
2017-08-07 8:34 ` Daniel Vetter
2017-08-07 8:34 ` Daniel Vetter
2017-10-09 17:18 ` Keith Packard
2017-10-09 17:18 ` Keith Packard
2017-10-10 8:55 ` Daniel Vetter
2017-10-10 8:55 ` Daniel Vetter
2017-08-02 9:45 ` Michel Dänzer
2017-08-06 3:42 ` Keith Packard
2017-08-06 3:42 ` Keith Packard
2017-08-07 3:03 ` Michel Dänzer
2017-08-07 3:03 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760egutih.fsf@keithp.com \
--to=keithp@keithp.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.