From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: pxa: fix GPIO double shifts
Date: Sun, 31 Jul 2016 11:12:32 +0200 [thread overview]
Message-ID: <8760rmyxvj.fsf@belgarion.home> (raw)
In-Reply-To: <1469896245.3998.113.camel@perches.com> (Joe Perches's message of "Sat, 30 Jul 2016 09:30:45 -0700")
Joe Perches <joe@perches.com> writes:
> On Sat, 2016-07-30 at 13:22 +0200, Robert Jarzmik wrote:
...zip...
> $ git grep -w charger_wakeup
> arch/arm/mach-pxa/corgi_pm.c:???.charger_wakeup??= corgi_charger_wakeup,
> arch/arm/mach-pxa/sharpsl_pm.c:?????????????????if (sharpsl_pm.machinfo->charger_wakeup() != 0)
> arch/arm/mach-pxa/sharpsl_pm.c:?????????if (sharpsl_pm.machinfo->charger_wakeup())
> arch/arm/mach-pxa/sharpsl_pm.h: unsigned long (*charger_wakeup)(void);
> arch/arm/mach-pxa/spitz_pm.c:???.charger_wakeup???= spitz_charger_wakeup,
...zip...
> It may be better to change the charger_wakeup callback return
> value from unsigned long to bool and modify the other use in
> spitz_pm.c?
You're most probably right. I'll do that for v3.
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Joe Perches <joe@perches.com>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: pxa: fix GPIO double shifts
Date: Sun, 31 Jul 2016 11:12:32 +0200 [thread overview]
Message-ID: <8760rmyxvj.fsf@belgarion.home> (raw)
In-Reply-To: <1469896245.3998.113.camel@perches.com> (Joe Perches's message of "Sat, 30 Jul 2016 09:30:45 -0700")
Joe Perches <joe@perches.com> writes:
> On Sat, 2016-07-30 at 13:22 +0200, Robert Jarzmik wrote:
...zip...
> $ git grep -w charger_wakeup
> arch/arm/mach-pxa/corgi_pm.c: .charger_wakeup = corgi_charger_wakeup,
> arch/arm/mach-pxa/sharpsl_pm.c: if (sharpsl_pm.machinfo->charger_wakeup() != 0)
> arch/arm/mach-pxa/sharpsl_pm.c: if (sharpsl_pm.machinfo->charger_wakeup())
> arch/arm/mach-pxa/sharpsl_pm.h: unsigned long (*charger_wakeup)(void);
> arch/arm/mach-pxa/spitz_pm.c: .charger_wakeup = spitz_charger_wakeup,
...zip...
> It may be better to change the charger_wakeup callback return
> value from unsigned long to bool and modify the other use in
> spitz_pm.c
You're most probably right. I'll do that for v3.
Cheers.
--
Robert
next prev parent reply other threads:[~2016-07-31 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 11:22 [PATCH v2] ARM: pxa: fix GPIO double shifts Robert Jarzmik
2016-07-30 11:22 ` Robert Jarzmik
2016-07-30 16:30 ` Joe Perches
2016-07-30 16:30 ` Joe Perches
2016-07-31 9:12 ` Robert Jarzmik [this message]
2016-07-31 9:12 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760rmyxvj.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.