From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Emil Velikov <emil.velikov@collabora.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v1 2/3] drm: Add API for capturing frame CRCs
Date: Thu, 23 Jun 2016 11:21:45 +0300 [thread overview]
Message-ID: <8760t0jox2.fsf@intel.com> (raw)
In-Reply-To: <CAKMK7uG-J=nx9xTdNbF4PBMYPpatRFVgdY-74CZ9EjmtE4gSRQ@mail.gmail.com>
On Wed, 22 Jun 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Jun 22, 2016 at 4:31 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
>> Perhaps another way to avoid that would be to put the two files into a
>> separate directory, as in:
>>
>> /sys/kernel/debug/dri/<minor>/crtc-<pipe>/crc/
>> +-- control
>> +-- data
>>
>> That's slightly on the deeply nested side, but on the other hand it
>> nicely uses the filesystem for namespacing, which is what filesystems
>> are really good at.
>
> crtc-<index>/crc/(control|data) sounds great.
Side note, we should eventually do the same for sink CRCs, but I guess
under the connectors. i915 currently has a special cased version for eDP
(named "i915_sink_crc_eDP1"...), reading the data from DPCD.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
"dri-devel\@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH v1 2/3] drm: Add API for capturing frame CRCs
Date: Thu, 23 Jun 2016 11:21:45 +0300 [thread overview]
Message-ID: <8760t0jox2.fsf@intel.com> (raw)
In-Reply-To: <CAKMK7uG-J=nx9xTdNbF4PBMYPpatRFVgdY-74CZ9EjmtE4gSRQ@mail.gmail.com>
On Wed, 22 Jun 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Jun 22, 2016 at 4:31 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
>> Perhaps another way to avoid that would be to put the two files into a
>> separate directory, as in:
>>
>> /sys/kernel/debug/dri/<minor>/crtc-<pipe>/crc/
>> +-- control
>> +-- data
>>
>> That's slightly on the deeply nested side, but on the other hand it
>> nicely uses the filesystem for namespacing, which is what filesystems
>> are really good at.
>
> crtc-<index>/crc/(control|data) sounds great.
Side note, we should eventually do the same for sink CRCs, but I guess
under the connectors. i915 currently has a special cased version for eDP
(named "i915_sink_crc_eDP1"...), reading the data from DPCD.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2016-06-23 8:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 11:06 [PATCH v1 0/3] New debugfs API for capturing CRC of frames Tomeu Vizoso
2016-06-21 11:06 ` Tomeu Vizoso
2016-06-21 11:06 ` [PATCH v1 1/3] drm/i915/debugfs: Move out pipe CRC code Tomeu Vizoso
2016-06-21 11:06 ` Tomeu Vizoso
2016-06-21 11:06 ` [PATCH v1 2/3] drm: Add API for capturing frame CRCs Tomeu Vizoso
2016-06-21 11:06 ` Tomeu Vizoso
2016-06-21 15:07 ` Thierry Reding
2016-06-21 15:07 ` Thierry Reding
2016-06-22 8:26 ` Tomeu Vizoso
2016-06-22 8:26 ` Tomeu Vizoso
2016-06-22 13:32 ` Thierry Reding
2016-06-22 13:32 ` Thierry Reding
2016-06-22 14:08 ` Daniel Vetter
2016-06-22 14:08 ` Daniel Vetter
2016-06-22 14:31 ` Thierry Reding
2016-06-22 14:31 ` Thierry Reding
2016-06-22 14:38 ` Daniel Vetter
2016-06-22 14:38 ` Daniel Vetter
2016-06-23 8:21 ` Jani Nikula [this message]
2016-06-23 8:21 ` Jani Nikula
2016-06-23 8:24 ` Tomeu Vizoso
2016-06-23 8:24 ` Tomeu Vizoso
2016-06-23 8:43 ` Thierry Reding
2016-06-23 8:43 ` Thierry Reding
2016-06-23 10:07 ` Daniel Vetter
2016-06-23 10:07 ` Daniel Vetter
2016-06-22 14:12 ` Daniel Vetter
2016-06-22 14:12 ` Daniel Vetter
2016-06-22 14:20 ` Daniel Vetter
2016-06-22 14:20 ` Daniel Vetter
2016-06-21 11:06 ` [PATCH v1 3/3] drm/i915: Use new CRC debugfs API Tomeu Vizoso
2016-06-21 11:06 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760t0jox2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.