From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "Thiagarajan, Vasanthakumar" <vthiagar@qti.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 1/2] ath10k: Define an enum to enable cycle counter wraparound logic
Date: Sat, 4 Jun 2016 14:53:54 +0000 [thread overview]
Message-ID: <8760tpt37i.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: 1464968596-19834-1-git-send-email-vthiagar@qti.qualcomm.com
Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> writes:
> QCA988X hw implements a different cycle counter wraparound
> behaviour when compared to QCA4019. To properly handle different
> wraparound logic for these chipsets replace already available
> bool hw_params member, has_shifted_cc_wraparound, with an
> enum which could be extended to handle different wraparound
> behaviour. This patch keeps the existing logic functionally
> same and a prepares cycle counter wraparound handling to
> extend for other chips.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -55,7 +55,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
> .name = "qca988x hw2.0",
> .patch_load_addr = QCA988X_HW_2_0_PATCH_LOAD_ADDR,
> .uart_pin = 7,
> - .has_shifted_cc_wraparound = true,
> + .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
> .otp_exe_param = 0,
> .channel_counters_freq_hz = 88000,
> .max_probe_resp_desc_thres = 0,
> @@ -224,7 +224,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
> .name = "qca4019 hw1.0",
> .patch_load_addr = QCA4019_HW_1_0_PATCH_LOAD_ADDR,
> .uart_pin = 7,
> - .has_shifted_cc_wraparound = true,
> + .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
> .otp_exe_param = 0x0010000,
> .continuous_frag_desc = true,
> .channel_counters_freq_hz = 125000,
As the pending branch has the QCA9887 patch I added
ATH10K_HW_CC_WRAP_SHIFTED_ALL also for QCA9887. Please review my changes
in the pending branch:
https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=2fa32dbd9f26e8b2f323ca30ad116ea486840aba
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "Thiagarajan, Vasanthakumar" <vthiagar@qti.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath10k: Define an enum to enable cycle counter wraparound logic
Date: Sat, 4 Jun 2016 14:53:54 +0000 [thread overview]
Message-ID: <8760tpt37i.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: 1464968596-19834-1-git-send-email-vthiagar@qti.qualcomm.com
Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> writes:
> QCA988X hw implements a different cycle counter wraparound
> behaviour when compared to QCA4019. To properly handle different
> wraparound logic for these chipsets replace already available
> bool hw_params member, has_shifted_cc_wraparound, with an
> enum which could be extended to handle different wraparound
> behaviour. This patch keeps the existing logic functionally
> same and a prepares cycle counter wraparound handling to
> extend for other chips.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -55,7 +55,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
> .name = "qca988x hw2.0",
> .patch_load_addr = QCA988X_HW_2_0_PATCH_LOAD_ADDR,
> .uart_pin = 7,
> - .has_shifted_cc_wraparound = true,
> + .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
> .otp_exe_param = 0,
> .channel_counters_freq_hz = 88000,
> .max_probe_resp_desc_thres = 0,
> @@ -224,7 +224,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
> .name = "qca4019 hw1.0",
> .patch_load_addr = QCA4019_HW_1_0_PATCH_LOAD_ADDR,
> .uart_pin = 7,
> - .has_shifted_cc_wraparound = true,
> + .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
> .otp_exe_param = 0x0010000,
> .continuous_frag_desc = true,
> .channel_counters_freq_hz = 125000,
As the pending branch has the QCA9887 patch I added
ATH10K_HW_CC_WRAP_SHIFTED_ALL also for QCA9887. Please review my changes
in the pending branch:
https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=2fa32dbd9f26e8b2f323ca30ad116ea486840aba
--
Kalle Valo
next prev parent reply other threads:[~2016-06-04 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 15:43 [PATCH 1/2] ath10k: Define an enum to enable cycle counter wraparound logic Vasanthakumar Thiagarajan
2016-06-03 15:43 ` Vasanthakumar Thiagarajan
2016-06-03 15:43 ` [PATCH 2/2] ath10k: Fix cycle counter wraparound handling for QCA4019 Vasanthakumar Thiagarajan
2016-06-03 15:43 ` Vasanthakumar Thiagarajan
2016-06-04 14:53 ` Valo, Kalle [this message]
2016-06-04 14:53 ` [PATCH 1/2] ath10k: Define an enum to enable cycle counter wraparound logic Valo, Kalle
2016-06-05 5:06 ` Thiagarajan, Vasanthakumar
2016-06-05 5:06 ` Thiagarajan, Vasanthakumar
2016-06-14 11:59 ` [1/2] " Kalle Valo
2016-06-14 11:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760tpt37i.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.