From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject
Date: Mon, 30 May 2016 13:56:00 +0200 [thread overview]
Message-ID: <8760tvep4f.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <b5a69ef7-81aa-89f1-cf3b-5cc9fdb03668@redhat.com> (John Snow's message of "Fri, 20 May 2016 17:27:02 -0400")
John Snow <jsnow@redhat.com> writes:
> It already got applied, but I can change it to your preference. (Always
> return an -errno and an Error, delete-and-free when we don't care about
> it...)
I think that would be an improvement. This is advice, not a demand :)
next prev parent reply other threads:[~2016-05-30 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 21:53 [Qemu-devel] [PATCH v2 0/1] block: clarify error message for qmp-eject John Snow
2016-05-18 21:53 ` [Qemu-devel] [PATCH v2 1/1] " John Snow
2016-05-18 22:05 ` Eric Blake
2016-05-19 1:24 ` Fam Zheng
2016-05-20 14:48 ` Markus Armbruster
2016-05-20 21:27 ` John Snow
2016-05-30 11:56 ` Markus Armbruster [this message]
2016-05-19 12:40 ` [Qemu-devel] [Qemu-block] [PATCH v2 0/1] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760tvep4f.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.