Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:

>> Ok, curses and gtk can't be active at the same time.  But for curses and
>> vnc it is possible (qemu -curses -vnc :$display), and you probably get a
>> dissorted vga text mode over vnc then.
>>
>> I think the mapping should happen in the curses code, when curses
>> updates the screen.  curses_update() function is probably the best place
>> for it.
>
> OK. It would be possible though, but parsing at curses_update() is
> slower. It is why, I did at that. Well, I'll see.

I've checked callers and usage of console_write_ch(). Call path is
following paths.

curses_refresh()
    graphic_hw_text_update(NULL, screen);
        ->text_update()
            vga_update_text()
                console_write_ch()

        ->text_update()
            jazz_led_text_update()
                console_write_ch()

        ->text_update()
            text_console_update()
                console_write_ch()

>From this call paths, graphic_hw_text_update() => console_write_ch() =>
->text_update() path is only used for -curses mode. What do you think?
(E.g. qemu is going to extend to use this for other purpose?)

I guess, rather qemu wants to remove the call of ->text_update() for
micro optimization if curses display is not used. (I'm not sure how
optimizes it right now though.)

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>