From: Rusty Russell <rusty@rustcorp.com.au>
To: Dan Streetman <ddstreet@ieee.org>,
Seth Jennings <sjennings@variantweb.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH 1/2] module: export param_free_charp()
Date: Thu, 27 Aug 2015 13:45:57 +0930 [thread overview]
Message-ID: <876141icxu.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1440613970-23913-2-git-send-email-ddstreet@ieee.org>
Dan Streetman <ddstreet@ieee.org> writes:
> Change the param_free_charp() function from static to exported.
>
> It is used by zswap in the next patch.
>
> Signed-off-by: Dan Streetman <ddstreet@ieee.org>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks!
Rusty.
> ---
> include/linux/moduleparam.h | 1 +
> kernel/params.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
> index c12f214..52666d9 100644
> --- a/include/linux/moduleparam.h
> +++ b/include/linux/moduleparam.h
> @@ -386,6 +386,7 @@ extern int param_get_ullong(char *buffer, const struct kernel_param *kp);
> extern const struct kernel_param_ops param_ops_charp;
> extern int param_set_charp(const char *val, const struct kernel_param *kp);
> extern int param_get_charp(char *buffer, const struct kernel_param *kp);
> +extern void param_free_charp(void *arg);
> #define param_check_charp(name, p) __param_check(name, p, char *)
>
> /* We used to allow int as well as bool. We're taking that away! */
> diff --git a/kernel/params.c b/kernel/params.c
> index b6554aa..93a380a 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -325,10 +325,11 @@ int param_get_charp(char *buffer, const struct kernel_param *kp)
> }
> EXPORT_SYMBOL(param_get_charp);
>
> -static void param_free_charp(void *arg)
> +void param_free_charp(void *arg)
> {
> maybe_kfree_parameter(*((char **)arg));
> }
> +EXPORT_SYMBOL(param_free_charp);
>
> const struct kernel_param_ops param_ops_charp = {
> .set = param_set_charp,
> --
> 2.1.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Dan Streetman <ddstreet@ieee.org>,
Seth Jennings <sjennings@variantweb.net>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>, Dan Streetman <ddstreet@ieee.org>
Subject: Re: [PATCH 1/2] module: export param_free_charp()
Date: Thu, 27 Aug 2015 13:45:57 +0930 [thread overview]
Message-ID: <876141icxu.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1440613970-23913-2-git-send-email-ddstreet@ieee.org>
Dan Streetman <ddstreet@ieee.org> writes:
> Change the param_free_charp() function from static to exported.
>
> It is used by zswap in the next patch.
>
> Signed-off-by: Dan Streetman <ddstreet@ieee.org>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks!
Rusty.
> ---
> include/linux/moduleparam.h | 1 +
> kernel/params.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
> index c12f214..52666d9 100644
> --- a/include/linux/moduleparam.h
> +++ b/include/linux/moduleparam.h
> @@ -386,6 +386,7 @@ extern int param_get_ullong(char *buffer, const struct kernel_param *kp);
> extern const struct kernel_param_ops param_ops_charp;
> extern int param_set_charp(const char *val, const struct kernel_param *kp);
> extern int param_get_charp(char *buffer, const struct kernel_param *kp);
> +extern void param_free_charp(void *arg);
> #define param_check_charp(name, p) __param_check(name, p, char *)
>
> /* We used to allow int as well as bool. We're taking that away! */
> diff --git a/kernel/params.c b/kernel/params.c
> index b6554aa..93a380a 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -325,10 +325,11 @@ int param_get_charp(char *buffer, const struct kernel_param *kp)
> }
> EXPORT_SYMBOL(param_get_charp);
>
> -static void param_free_charp(void *arg)
> +void param_free_charp(void *arg)
> {
> maybe_kfree_parameter(*((char **)arg));
> }
> +EXPORT_SYMBOL(param_free_charp);
>
> const struct kernel_param_ops param_ops_charp = {
> .set = param_set_charp,
> --
> 2.1.0
next prev parent reply other threads:[~2015-08-28 0:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 18:32 [PATCH 0/2] zswap: use charp type params instead of fixed-len strings Dan Streetman
2015-08-26 18:32 ` Dan Streetman
2015-08-26 18:32 ` [PATCH 1/2] module: export param_free_charp() Dan Streetman
2015-08-26 18:32 ` Dan Streetman
2015-08-27 4:15 ` Rusty Russell [this message]
2015-08-27 4:15 ` Rusty Russell
2015-08-26 18:32 ` [PATCH 2/2] zswap: use charp for zswap param strings Dan Streetman
2015-08-26 18:32 ` Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876141icxu.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sjennings@variantweb.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.