All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>
Subject: Re: [Qemu-trivial] [PATCH v2] 9pfs-local: simplify/optimize local_mapped_attr_path()
Date: Thu, 12 Mar 2015 15:23:55 +0530	[thread overview]
Message-ID: <8761a6bky4.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1426143150-5641-1-git-send-email-mjt@msgid.tls.msk.ru>

Michael Tokarev <mjt@tls.msk.ru> writes:

> Omit one unnecessary memory allocation for components
> of the path and create the resulting path directly given
> lengths of the components.
>
> Do not use basename(3) because there are 2 versions of
> this function which differs when argument ends with
> slash character, use strrchr() instead so we have
> consistent result.  This also makes sure the function
> will do the right thing in corner cases (eg, empty
> pathname is given), when basename(3) return entirely
> another string.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

Applied.

Thanks
-aneesh



WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] 9pfs-local: simplify/optimize local_mapped_attr_path()
Date: Thu, 12 Mar 2015 15:23:55 +0530	[thread overview]
Message-ID: <8761a6bky4.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1426143150-5641-1-git-send-email-mjt@msgid.tls.msk.ru>

Michael Tokarev <mjt@tls.msk.ru> writes:

> Omit one unnecessary memory allocation for components
> of the path and create the resulting path directly given
> lengths of the components.
>
> Do not use basename(3) because there are 2 versions of
> this function which differs when argument ends with
> slash character, use strrchr() instead so we have
> consistent result.  This also makes sure the function
> will do the right thing in corner cases (eg, empty
> pathname is given), when basename(3) return entirely
> another string.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

Applied.

Thanks
-aneesh

  reply	other threads:[~2015-03-12 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12  6:52 [Qemu-trivial] [PATCH v2] 9pfs-local: simplify/optimize local_mapped_attr_path() Michael Tokarev
2015-03-12  6:52 ` [Qemu-devel] " Michael Tokarev
2015-03-12  9:53 ` Aneesh Kumar K.V [this message]
2015-03-12  9:53   ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761a6bky4.fsf@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.