From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>, linux-kernel@vger.kernel.org
Cc: jason@lakedaemon.net, herbert@gondor.apana.org.au,
keescook@chromium.org,
Virtualization List <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v2 3/4] virtio: rng: delay hwrng_register() till driver is ready
Date: Wed, 23 Jul 2014 15:21:13 +0930 [thread overview]
Message-ID: <8761iozkq6.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20140722170834.GA23129@grmbl.mre>
Amit Shah <amit.shah@redhat.com> writes:
> On (Mon) 21 Jul 2014 [17:15:51], Amit Shah wrote:
>> Instead of calling hwrng_register() in the probe routing, call it in the
>> scan routine. This ensures that when hwrng_register() is successful,
>> and it requests a few random bytes to seed the kernel's pool at init,
>> we're ready to service that request.
>>
>> This will also enable us to remove the workaround added previously to
>> check whether probe was completed, and only then ask for data from the
>> host. The revert follows in the next commit.
>>
>> There's a slight behaviour change here on unsuccessful hwrng_register().
>> Previously, when hwrng_unregister() failed, the probe() routine would
>
> typo: should be hwrng_register().
>
> Please fix this up when picking up the patch.
Done.
All 4 patches applied!
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>, linux-kernel@vger.kernel.org
Cc: Virtualization List <virtualization@lists.linux-foundation.org>,
herbert@gondor.apana.org.au, keescook@chromium.org,
jason@lakedaemon.net, Amos Kong <akong@redhat.com>
Subject: Re: [PATCH v2 3/4] virtio: rng: delay hwrng_register() till driver is ready
Date: Wed, 23 Jul 2014 15:21:13 +0930 [thread overview]
Message-ID: <8761iozkq6.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20140722170834.GA23129@grmbl.mre>
Amit Shah <amit.shah@redhat.com> writes:
> On (Mon) 21 Jul 2014 [17:15:51], Amit Shah wrote:
>> Instead of calling hwrng_register() in the probe routing, call it in the
>> scan routine. This ensures that when hwrng_register() is successful,
>> and it requests a few random bytes to seed the kernel's pool at init,
>> we're ready to service that request.
>>
>> This will also enable us to remove the workaround added previously to
>> check whether probe was completed, and only then ask for data from the
>> host. The revert follows in the next commit.
>>
>> There's a slight behaviour change here on unsuccessful hwrng_register().
>> Previously, when hwrng_unregister() failed, the probe() routine would
>
> typo: should be hwrng_register().
>
> Please fix this up when picking up the patch.
Done.
All 4 patches applied!
Rusty.
next prev parent reply other threads:[~2014-07-23 5:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 11:45 [PATCH v2 0/4] virtio-rng: contribute to early randomness requests Amit Shah
2014-07-21 11:45 ` Amit Shah
2014-07-21 11:45 ` [PATCH v2 1/4] virtio: rng: remove unused struct element Amit Shah
2014-07-21 11:45 ` Amit Shah
2014-07-21 11:45 ` [PATCH v2 2/4] virtio: rng: re-arrange struct elements for better packing Amit Shah
2014-07-21 11:45 ` Amit Shah
2014-07-21 11:45 ` [PATCH v2 3/4] virtio: rng: delay hwrng_register() till driver is ready Amit Shah
2014-07-21 11:45 ` Amit Shah
2014-07-21 12:11 ` Jason Cooper
2014-07-21 12:11 ` Jason Cooper
2014-07-21 12:21 ` Amit Shah
2014-07-21 12:21 ` Amit Shah
2014-07-21 12:41 ` Herbert Xu
2014-07-21 12:41 ` Herbert Xu
2014-07-22 11:43 ` Jason Cooper
2014-07-22 11:43 ` Jason Cooper
2014-07-22 17:08 ` Amit Shah
2014-07-22 17:08 ` Amit Shah
2014-07-23 5:51 ` Rusty Russell [this message]
2014-07-23 5:51 ` Rusty Russell
2014-07-21 11:45 ` [PATCH v2 4/4] Revert "hwrng: virtio - ensure reads happen after successful probe" Amit Shah
2014-07-21 11:45 ` Amit Shah
2014-07-22 11:46 ` [PATCH v2 0/4] virtio-rng: contribute to early randomness requests Jason Cooper
2014-07-22 11:46 ` Jason Cooper
2014-07-22 15:08 ` Amit Shah
2014-07-22 15:08 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761iozkq6.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jason@lakedaemon.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.