[PATCH] mmc: sdhci: Log what timeout was set if the timeout is too large

[PATCH] mmc: sdhci: Log what timeout was set if the timeout is too large

[Mark Brown]

Rather than just logging that we came up with an excessively large timeout
say what the timeout was, this may provide some clues as to what the issue
is.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

I'm seeing reams of these from my s3c64xx based system, looks like it's
always coming out with a timeout of 0xf which is only just out of range.

 drivers/mmc/host/sdhci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 9aa77f3..8407a0b 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -680,8 +680,8 @@ static u8 sdhci_calc_timeout(struct sdhci_host *host, struct mmc_command *cmd)
 	}
 
 	if (count >= 0xF) {
-		pr_warning("%s: Too large timeout requested for CMD%d!\n",
-		       mmc_hostname(host->mmc), cmd->opcode);
+		pr_warning("%s: Too large timeout %x requested for CMD%d!\n",
+			   mmc_hostname(host->mmc), count, cmd->opcode);
 		count = 0xE;
 	}
 
-- 
1.7.9.1

Re: [PATCH] mmc: sdhci: Log what timeout was set if the timeout is too large

[Chris Ball]

Hi Mark,

On Tue, Apr 10 2012, Mark Brown wrote:
> Rather than just logging that we came up with an excessively large timeout
> say what the timeout was, this may provide some clues as to what the issue
> is.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>
> I'm seeing reams of these from my s3c64xx based system, looks like it's
> always coming out with a timeout of 0xf which is only just out of range.
>
>  drivers/mmc/host/sdhci.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 9aa77f3..8407a0b 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -680,8 +680,8 @@ static u8 sdhci_calc_timeout(struct sdhci_host *host, struct mmc_command *cmd)
>  	}
>  
>  	if (count >= 0xF) {
> -		pr_warning("%s: Too large timeout requested for CMD%d!\n",
> -		       mmc_hostname(host->mmc), cmd->opcode);
> +		pr_warning("%s: Too large timeout %x requested for CMD%d!\n",
> +			   mmc_hostname(host->mmc), count, cmd->opcode);
>  		count = 0xE;
>  	}

Thanks, pushed to mmc-next for 3.5 with a trivial change:

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 8407a0b..6868893 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -680,7 +680,7 @@ static u8 sdhci_calc_timeout(struct sdhci_host *host, struct mmc_command *cmd)
 	}
 
 	if (count >= 0xF) {
-		pr_warning("%s: Too large timeout %x requested for CMD%d!\n",
+		pr_warning("%s: Too large timeout 0x%x requested for CMD%d!\n",
 			   mmc_hostname(host->mmc), count, cmd->opcode);
 		count = 0xE;
 	}

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child